Fix an invalid default value cause bootstrap failed by Lloyd-Pottiger · Pull Request #4916 · pingcap/tiflash

Lloyd-Pottiger · 2022-05-18T06:15:40Z

What problem does this PR solve?

Issue Number: close #3157

Problem Summary:

What is changed and how it works?

when value is 0.0, value.convert<Int64>(); raise a error.
Convert it to String first, and convert String to Int64 by std::stoull
static_cast<Int64>(std::stoull(value.convert<String>()));

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot · 2022-05-18T06:15:41Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JaySon-Huang
flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Lloyd-Pottiger · 2022-05-18T06:18:56Z

mysql test> create table t (a int);
-- The type of column i is int, but the default value is set to "0.00"
mysql test> alter table t add column i int not null default 0.00; 
mysql test> alter tablet t set tiflash replica 1;
mysql test> select a from t;

dbms/src/Storages/Transaction/TiDB.cpp

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

Lloyd-Pottiger · 2022-05-27T06:44:37Z

mysql> use test
Database changed
mysql> create table t (a int default 0.0);
Query OK, 0 rows affected (0.07 sec)

mysql> ALTER TABLE t SET TIFLASH REPLICA 1;
Query OK, 0 rows affected (0.07 sec)

mysql> show create table t;
+-------+------------------------------------------------------------------------------------------------------------+
| Table | Create Table                                                                                               |
+-------+------------------------------------------------------------------------------------------------------------+
| t     | CREATE TABLE `t` (
  `a` int(11) DEFAULT '0.0'
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin |
+-------+------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

mysql> insert t (a) values(default);
Query OK, 1 row affected (0.01 sec)

mysql> select a from t;
+------+
| a    |
+------+
|    0 |
+------+
1 row in set (0.25 sec)

mysql> alter table t change a a int default 1.25;
Query OK, 0 rows affected (0.06 sec)

mysql> insert t (a) values(default);
Query OK, 1 row affected (0.00 sec)

mysql> select a from t;
+------+
| a    |
+------+
|    0 |
|    1 |
+------+
2 rows in set (0.02 sec)

mysql> alter table t change a a int default 2.8;
Query OK, 0 rows affected (0.06 sec)

mysql> insert t (a) values(default);
Query OK, 1 row affected (0.01 sec)

mysql> select a from t;
+------+
| a    |
+------+
|    0 |
|    1 |
|    3 |
+------+
3 rows in set (0.02 sec)

Lloyd-Pottiger · 2022-05-27T06:49:44Z

/run-all-tests

Lloyd-Pottiger · 2022-05-27T07:12:51Z

/rebuild

sre-bot · 2022-05-27T07:18:43Z

Coverage for changed files

Filename                                                                                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/TiDB.cpp         480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                     480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18154      9788             46.08%    202642  97933        51.67%

full coverage report (for internal network access only)

JaySon-Huang

LGTM

Lloyd-Pottiger · 2022-05-27T08:02:41Z

/merge

sre-bot · 2022-05-27T11:13:51Z

Coverage for changed files

Filename                                                                                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/TiDB.cpp         480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                     480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18277      9785             46.46%    204804  98125        52.09%

full coverage report (for internal network access only)

ti-chi-bot · 2022-05-27T11:25:25Z

In response to a cherrypick label: new pull request created: #5025.

ti-chi-bot · 2022-05-27T11:26:01Z

In response to a cherrypick label: new pull request created: #5026.

close #3157

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-07-11T03:30:23Z

In response to a cherrypick label: new pull request created: #5330.

ti-chi-bot · 2022-07-11T03:30:24Z

In response to a cherrypick label: new pull request created: #5331.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-07-11T03:30:25Z

In response to a cherrypick label: new pull request created: #5332.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-07-11T03:30:26Z

In response to a cherrypick label: new pull request created: #5333.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-07-11T03:30:27Z

In response to a cherrypick label: new pull request created: #5334.

close #3157

Lloyd-Pottiger added 3 commits May 17, 2022 19:53

add a try catch statement for convert Poco::Dynamic::Var to Int64

f7a0fd8

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

remove useless include

6f0c1f1

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

fix remove mistakenly

bd35f5f

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot added needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2022

format

279ee2e

ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 18, 2022

breezewish reviewed May 23, 2022

View reviewed changes

dbms/src/Storages/Transaction/TiDB.cpp Outdated Show resolved Hide resolved

JaySon-Huang reviewed May 24, 2022

View reviewed changes

dbms/src/Storages/Transaction/TiDB.cpp Show resolved Hide resolved

Lloyd-Pottiger requested review from JaySon-Huang and breezewish May 25, 2022 01:49

flowbehappy self-requested a review May 27, 2022 04:23

flowbehappy approved these changes May 27, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022

fix

334a048

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label May 27, 2022

Lloyd-Pottiger added 2 commits May 27, 2022 12:34

remove useless comment

d8b3baf

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

add comments for unsigned

e239ead

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>

JaySon-Huang approved these changes May 27, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022

ti-chi-bot merged commit ca3e1c6 into pingcap:master May 27, 2022

ti-chi-bot mentioned this pull request May 27, 2022

Fix an invalid default value cause bootstrap failed (#4916) #5025

Closed

12 tasks

ti-chi-bot mentioned this pull request May 27, 2022

Fix an invalid default value cause bootstrap failed (#4916) #5026

Merged

12 tasks

Lloyd-Pottiger deleted the fix-invalid-default-value branch May 27, 2022 11:36

ti-chi-bot added a commit that referenced this pull request May 27, 2022

Fix an invalid default value cause bootstrap failed (#4916) (#5026)

aa3c561

close #3157

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 11, 2022

This is an automated cherry-pick of pingcap#4916

6c22b5f

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 11, 2022

Fix an invalid default value cause bootstrap failed (#4916) #5330

Closed

12 tasks

ti-chi-bot mentioned this pull request Jul 11, 2022

Fix an invalid default value cause bootstrap failed (#4916) #5331

Merged

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 11, 2022

This is an automated cherry-pick of pingcap#4916

cdc7e8b

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 11, 2022

Fix an invalid default value cause bootstrap failed (#4916) #5332

Closed

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 11, 2022

This is an automated cherry-pick of pingcap#4916

2774dae

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 11, 2022

Fix an invalid default value cause bootstrap failed (#4916) #5333

Merged

12 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 11, 2022

This is an automated cherry-pick of pingcap#4916

05e4aca

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 11, 2022

Fix an invalid default value cause bootstrap failed (#4916) #5334

Merged

12 tasks

ti-chi-bot added a commit that referenced this pull request Sep 27, 2022

Fix an invalid default value cause bootstrap failed (#4916) (#5334)

72ece8b

close #3157

ti-chi-bot added a commit that referenced this pull request Nov 8, 2022

Fix an invalid default value cause bootstrap failed (#4916) (#5331)

5b6910f

close #3157

ti-chi-bot added a commit that referenced this pull request Dec 8, 2022

Fix an invalid default value cause bootstrap failed (#4916) (#5333)

b9544eb

close #3157

Conversation

Lloyd-Pottiger commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Lloyd-Pottiger commented May 18, 2022

Uh oh!

Uh oh!

Uh oh!

Lloyd-Pottiger commented May 27, 2022

Uh oh!

Lloyd-Pottiger commented May 27, 2022

Uh oh!

Lloyd-Pottiger commented May 27, 2022

Uh oh!

sre-bot commented May 27, 2022

Coverage for changed files

Coverage summary

Uh oh!

JaySon-Huang left a comment

Choose a reason for hiding this comment

Uh oh!

Lloyd-Pottiger commented May 27, 2022

Uh oh!

sre-bot commented May 27, 2022

Coverage for changed files

Coverage summary

Uh oh!

ti-chi-bot commented May 27, 2022

Uh oh!

ti-chi-bot commented May 27, 2022

Uh oh!

ti-chi-bot commented Jul 11, 2022

Uh oh!

ti-chi-bot commented Jul 11, 2022

Uh oh!

ti-chi-bot commented Jul 11, 2022

Uh oh!

ti-chi-bot commented Jul 11, 2022

Uh oh!

ti-chi-bot commented Jul 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Lloyd-Pottiger commented May 18, 2022 •

edited

Loading

ti-chi-bot commented May 18, 2022 •

edited

Loading