Skip to content

Fix an invalid default value cause bootstrap failed (#4916)#5334

Merged
ti-chi-bot merged 4 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-4916-to-release-5.4
Sep 27, 2022
Merged

Fix an invalid default value cause bootstrap failed (#4916)#5334
ti-chi-bot merged 4 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-4916-to-release-5.4

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 11, 2022

This is an automated cherry-pick of #4916

What problem does this PR solve?

Issue Number: close #3157

Problem Summary:

What is changed and how it works?

when value is 0.0, value.convert<Int64>(); raise a error.
Convert it to String first, and convert String to Int64 by std::stoull
static_cast<Int64>(std::stoull(value.convert<String>()));

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger @ti-chi-bot
This is an automated cherry-pick of pingcap#4916
05e4aca 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jul 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 11, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Jul 11, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 11, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2022
@JaySon-Huang JaySon-Huang added this to the v5.4.3 milestone Sep 14, 2022
@flowbehappy flowbehappy self-requested a review September 27, 2022 08:30
@Lloyd-Pottiger
Copy link
Contributor

Lloyd-Pottiger commented Sep 27, 2022

/rebuild

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2022
Lloyd-Pottiger
Lloyd-Pottiger reviewed Sep 27, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 27, 2022
@flowbehappy
Copy link
Contributor

flowbehappy commented Sep 27, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 27, 2022

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d9c7bd6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 27, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 27, 2022

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 27, 2022

lines: 30.2% (3259 out of 10801)
branches: 13.6% (2332 out of 17143)

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 27, 2022

lines: 30.2% (3259 out of 10801)
branches: 13.6% (2333 out of 17143)

@ti-chi-bot ti-chi-bot merged commit 72ece8b into pingcap:release-5.4 Sep 27, 2022
@ti-chi-bot ti-chi-bot deleted the cherry-pick-4916-to-release-5.4 branch April 15, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger left review comments

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@Lloyd-Pottiger Lloyd-Pottiger

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.

Projects

None yet

Milestone

v5.4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @Lloyd-Pottiger @flowbehappy @sre-bot @JaySon-Huang @VelocityLight