Skip to content

Fix an invalid default value cause bootstrap failed (#4916)#5025

Closed
ti-chi-bot wants to merge 9 commits intopingcap:release-6.0from
ti-chi-bot:cherry-pick-4916-to-release-6.0
Closed

Fix an invalid default value cause bootstrap failed (#4916)#5025
ti-chi-bot wants to merge 9 commits intopingcap:release-6.0from
ti-chi-bot:cherry-pick-4916-to-release-6.0

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 27, 2022

This is an automated cherry-pick of #4916

What problem does this PR solve?

Issue Number: close #3157

Problem Summary:

What is changed and how it works?

when value is 0.0, value.convert<Int64>(); raise a error.
Convert it to String first, and convert String to Int64 by std::stoull
static_cast<Int64>(std::stoull(value.convert<String>()));

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger @ti-chi-bot
add a try catch statement for convert Poco::Dynamic::Var to Int64
78c0b54 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger @ti-chi-bot
remove useless include
9283754 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger @ti-chi-bot
fix remove mistakenly
ec90f56 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger @ti-chi-bot
format
bb13ec0
@Lloyd-Pottiger @ti-chi-bot
fix
4f3ece5 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger @ti-chi-bot
remove useless comment
d86783b 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger @ti-chi-bot
add comments for unsigned
381766b 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger @ti-chi-bot
format
cc0fcaf
@Lloyd-Pottiger @ti-chi-bot
clear tidy
026a8ca
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels May 27, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 27, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.0 labels May 27, 2022
@Lloyd-Pottiger
Copy link
Contributor

Lloyd-Pottiger commented May 27, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                                                                                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/TiDB.cpp         476               269    43.49%          45                13    71.11%         852               398    53.29%         330               149    54.85%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                     476               269    43.49%          45                13    71.11%         852               398    53.29%         330               149    54.85%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16980      9544             43.79%    191351  96884        49.37%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@Lloyd-Pottiger
Copy link
Contributor

Lloyd-Pottiger commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 026a8ca

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                                                                                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/TiDB.cpp         476               269    43.49%          45                13    71.11%         852               398    53.29%         330               149    54.85%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                     476               269    43.49%          45                13    71.11%         852               398    53.29%         330               149    54.85%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16980      9544             43.79%    191351  96897        49.36%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jun 17, 2022

close as no further patch version for the 6.0 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

+1 more reviewer

@jiaqizho jiaqizho jiaqizho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Lloyd-Pottiger Lloyd-Pottiger

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @Lloyd-Pottiger @sre-bot @JaySon-Huang @jiaqizho