fix a bug that ExchangeReceiver can't be canceled#4441
Conversation
Signed-off-by: bestwoody <bestwoody@163.com>
…ugfix_cancel_recv
Signed-off-by: bestwoody <bestwoody@163.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
| if (!setEndState(ExchangeReceiverState::CANCELED)) | ||
| return; |
There was a problem hiding this comment.
| if (!setEndState(ExchangeReceiverState::CANCELED)) | |
| return; | |
| setEndState(ExchangeReceiverState::CANCELED); |
it's ok for finishing a queue twice.
| void ExchangeReceiverBase<RPCContext>::setState(ExchangeReceiverState new_state) | ||
| bool ExchangeReceiverBase<RPCContext>::setEndState(ExchangeReceiverState new_state) | ||
| { | ||
| assert(new_state == ExchangeReceiverState::CANCELED || new_state == ExchangeReceiverState::CLOSED); |
There was a problem hiding this comment.
please use RUNTIME_ASSERT.
There was a problem hiding this comment.
experimental , we can updated in future
Signed-off-by: bestwoody <bestwoody@163.com>
|
/merge |
|
@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@bestwoody: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/rebuild |
1 similar comment
|
/rebuild |
|
/merge |
|
@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/merge |
|
/rebuild |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/merge |
|
@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
In response to a cherrypick label: new pull request created: #4445. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created: #4532. |
This reverts commit 25e2a26.
* This is an automated cherry-pick of #4441 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * Revert "This is an automated cherry-pick of #4441" This reverts commit 25e2a26. * cherry pick * format * pass code stlye check Co-authored-by: bestwoody <89765764+bestwoody@users.noreply.github.com> Co-authored-by: bestwoody <bestwoody@163.com>
What problem does this PR solve?
Issue Number: close #4432
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note