Skip to content

fix a bug that ExchangeReceiver can't be canceled (#4441)#4532

Merged
bestwoody merged 5 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-4441-to-release-5.4
Apr 14, 2022
Merged

fix a bug that ExchangeReceiver can't be canceled (#4441)#4532
bestwoody merged 5 commits intopingcap:release-5.4from
ti-chi-bot:cherry-pick-4441-to-release-5.4

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Mar 31, 2022

This is an automated cherry-pick of #4441

What problem does this PR solve?

Issue Number: close #4432

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@bestwoody @ti-chi-bot
This is an automated cherry-pick of pingcap#4441
25e2a26 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 31, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 31, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bestwoody
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Mar 31, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 31, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022
windtalker
windtalker approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2022
@bestwoody
Copy link
Contributor

bestwoody commented Apr 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: aae8105

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@bestwoody
Copy link
Contributor

bestwoody commented Apr 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@bestwoody
Copy link
Contributor

bestwoody commented Apr 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 639c406

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 14, 2022

lines: 43.3% (49810 out of 115134)
branches: 6.4% (81427 out of 1263918)

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@bestwoody
Copy link
Contributor

bestwoody commented Apr 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 14, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1e93fa9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 14, 2022

lines: 43.3% (49811 out of 115134)
branches: 6.4% (81428 out of 1263918)

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 14, 2022
@bestwoody bestwoody merged commit 666049d into pingcap:release-5.4 Apr 14, 2022
@purelind purelind added this to the v5.4.1 milestone Apr 29, 2022
@ti-chi-bot ti-chi-bot deleted the cherry-pick-4441-to-release-5.4 branch April 15, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

+1 more reviewer

@bestwoody bestwoody bestwoody approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bestwoody bestwoody

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @bestwoody @sre-bot @windtalker @VelocityLight @purelind