Skip to content

fix a bug that ExchangeReceiver can't be canceled (#4441)#4664

Merged
bestwoody merged 3 commits intorelease-5.4-20220312from
cherry-pick-4441-to-release-5.4
Apr 14, 2022
Merged

fix a bug that ExchangeReceiver can't be canceled (#4441)#4664
bestwoody merged 3 commits intorelease-5.4-20220312from
cherry-pick-4441-to-release-5.4

Conversation

@bestwoody
Copy link
Contributor

@bestwoody bestwoody commented Apr 14, 2022 •
edited
Loading

This is an cherry-pick of #4441

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

bestwoody and others added 3 commits March 31, 2022 07:35
@bestwoody @ti-chi-bot
This is an automated cherry-pick of #4441
25e2a26 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@bestwoody
Revert "This is an automated cherry-pick of #4441"
61c06fb 
This reverts commit 25e2a26.
@bestwoody
cherry pick
aae8105
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Apr 14, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022

@bestwoody: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bestwoody bestwoody requested a review from SeaRise April 14, 2022 09:48
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2022
@bestwoody bestwoody requested a review from windtalker April 14, 2022 09:48
windtalker
windtalker approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022
@bestwoody bestwoody merged commit 997cdb0 into release-5.4-20220312 Apr 14, 2022
@purelind purelind added this to the v5.4.1 milestone Apr 29, 2022
@ngaut ngaut deleted the cherry-pick-4441-to-release-5.4 branch June 16, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@SeaRise SeaRise Awaiting requested review from SeaRise

Assignees

No one assigned

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@bestwoody @ti-chi-bot @windtalker @purelind