Skip to content

Fix bugs for PageStorage GC (release-5.0)#2336

Merged
ti-chi-bot merged 6 commits intopingcap:release-5.0from
ti-srebot:release-5.0-f9245feb6ccc
Sep 1, 2021
Merged

Fix bugs for PageStorage GC (release-5.0)#2336
ti-chi-bot merged 6 commits intopingcap:release-5.0from
ti-srebot:release-5.0-f9245feb6ccc

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jul 6, 2021

cherry-pick #2312 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2336

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2336:release-5.0-f9245feb6ccc

Signed-off-by: JaySon-Huang jayson.hjs@gmail.com

What problem does this PR solve?

Fix PageStorage GC related bugs

Release note

  • Fix the potential issue that TiFlash cannot GC the delta data after running for a long time

@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. labels Jul 6, 2021
@ti-srebot ti-srebot requested a review from flowbehappy July 6, 2021 08:48
@ti-srebot ti-srebot added this to the v5.0.4 milestone Jul 6, 2021
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts

@JaySon-Huang JaySon-Huang changed the title Ignore sequence hole among PageFile meta (#2312) [DNM] Ignore sequence hole among PageFile meta (#2312) Jul 6, 2021
@JaySon-Huang JaySon-Huang force-pushed the release-5.0-f9245feb6ccc branch from aaca013 to c1c4d08 Compare August 4, 2021 14:15
@JaySon-Huang JaySon-Huang changed the title [DNM] Ignore sequence hole among PageFile meta (#2312) Fix bugs for PageStorage GC #2337 Aug 4, 2021
@JaySon-Huang JaySon-Huang changed the title Fix bugs for PageStorage GC #2337 Fix bugs for PageStorage GC (release-5.0) Aug 4, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v5.0.4, v5.0.5 Aug 4, 2021
@JaySon-Huang
Copy link
Contributor

/run-all-tests

2 similar comments
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang JaySon-Huang modified the milestones: v5.0.5, v5.0.4 Aug 6, 2021
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 1, 2021
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 18a1ef0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 1, 2021
@ti-chi-bot ti-chi-bot merged commit f76da5e into pingcap:release-5.0 Sep 1, 2021
windtalker added a commit that referenced this pull request Sep 6, 2021
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
@JaySon-Huang JaySon-Huang deleted the release-5.0-f9245feb6ccc branch October 11, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CHERRY-PICK cherry pick cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants