Add time and thread_id for snapshot to check stale snapshots (#2229)#2239
Merged
JaySon-Huang merged 6 commits intopingcap:release-5.0from Jun 23, 2021
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
|
/run-all-tests |
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
|
merge the changes from #2241 |
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
|
/run-all-tests |
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Jun 29, 2021
…ingcap#2229) (pingcap#2239)" This reverts commit 6eab68e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #2229 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2239After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: related to #2199
Problem Summary: Suspicious that some tasks hold snapshot for a long time, prevent PageStorage from GCing old PageFiles
What is changed and how it works?
Add create_time and thread_id when creating snapshots. After
PageStorage::gc, log the oldest snapshot living time and its thread_id.We can trace to thread_id to know whether the snapshot is created for reading / background task.
When the create_time and thread_id and the period of logging files, we can know exactly which task holds the snapshot for a long time.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note