Skip to content

Add snapshot metrics for compact delta to check stale snapshots#2241

Merged
JaySon-Huang merged 4 commits intopingcap:masterfrom
JaySon-Huang:stale_ps_snapshot_logging
Jun 23, 2021
Merged

Add snapshot metrics for compact delta to check stale snapshots#2241
JaySon-Huang merged 4 commits intopingcap:masterfrom
JaySon-Huang:stale_ps_snapshot_logging

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jun 23, 2021 •
edited
Loading

Signed-off-by: JaySon-Huang jayson.hjs@gmail.com

What problem does this PR solve?

Issue Number: related to #2199 #2229

Problem Summary: Add snapshot metrics for compact delta

What is changed and how it works?

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

  • No release note

JaySon-Huang and others added 3 commits June 23, 2021 14:52
@JaySon-Huang
Add snapshot metrics for compact delta
5cfef8d 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Add grafana hidden metrics
382bb6e 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Merge branch 'master' into stale_ps_snapshot_logging
8aa2318
This was referenced Jun 23, 2021
Merged
Merged
Closed
@JaySon-Huang JaySon-Huang requested a review from flowbehappy June 23, 2021 08:34
@JaySon-Huang JaySon-Huang self-assigned this Jun 23, 2021
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 23, 2021

/run-all-tests

@jiangyuzhao jiangyuzhao force-pushed the stale_ps_snapshot_logging branch from 0d29149 to 08344c1 Compare June 23, 2021 09:28
@JaySon-Huang
Adjust some historgram panels
86f8bf0 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@jiangyuzhao jiangyuzhao force-pushed the stale_ps_snapshot_logging branch from 08344c1 to 86f8bf0 Compare June 23, 2021 09:31
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 23, 2021

/run-all-tests

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 23, 2021 

[2021-06-23T09:50:46.101Z] Creating mutable-test_tics0_1 ... 
[2021-06-23T09:51:53.833Z] 
[2021-06-23T09:51:53.833Z] ERROR: for mutable-test_tics0_1  HTTPConnectionPool(host='localhost', port=2375): Read timed out. (read timeout=60)
[2021-06-23T09:51:53.833Z] 
[2021-06-23T09:51:53.833Z] ERROR: for tics0  HTTPConnectionPool(host='localhost', port=2375): Read timed out. (read timeout=60)
[2021-06-23T09:51:53.833Z] An HTTP request took too long to complete. Retry with --verbose to obtain debug information.
[2021-06-23T09:51:53.833Z] If you encounter this issue regularly because of slow network conditions, consider setting COMPOSE_HTTP_TIMEOUT to a higher value (current value: 60).

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 23, 2021

/run-all-tests

1 similar comment
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jun 23, 2021

/run-all-tests

flowbehappy
flowbehappy approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2021
@JaySon-Huang JaySon-Huang merged commit 98deabd into pingcap:master Jun 23, 2021
@JaySon-Huang JaySon-Huang deleted the stale_ps_snapshot_logging branch June 23, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees

@JaySon-Huang JaySon-Huang

Labels

status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaySon-Huang @flowbehappy @ti-srebot