Skip to content

Fix address alignment error#10175

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
windtalker:fix_address_alignment_error
May 19, 2025
Merged

Fix address alignment error#10175
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
windtalker:fix_address_alignment_error

Conversation

@windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #10163

Problem Summary:

Ref to #10163

What is changed and how it works?

Use alignAlloc instead alloc to alloc memory for CachedColumnInfo

Fix TiFlash crash due to invalid address alignment

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 16, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 16, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-16 06:00:55.936254308 +0000 UTC m=+92422.192151705: ☑️ agreed by guo-shaoge.
  • 2025-05-16 06:47:05.082322963 +0000 UTC m=+95191.338220356: ☑️ agreed by gengliqi.

@windtalker
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2025
@windtalker
Copy link
Contributor Author

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2025
@windtalker
Copy link
Contributor Author

/test pull-integration-test

@windtalker windtalker force-pushed the fix_address_alignment_error branch from 08d0f37 to e202b2b Compare May 19, 2025 01:33
@ti-chi-bot ti-chi-bot bot removed the approved label May 19, 2025
windtalker and others added 4 commits May 19, 2025 11:01
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker windtalker force-pushed the fix_address_alignment_error branch from e202b2b to 3edf853 Compare May 19, 2025 03:01
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, guo-shaoge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gengliqi,guo-shaoge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 19, 2025
@ti-chi-bot ti-chi-bot bot merged commit d9e6109 into pingcap:master May 19, 2025
5 checks passed
@windtalker windtalker deleted the fix_address_alignment_error branch May 19, 2025 03:54
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels May 19, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #10182.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #10183.

ti-chi-bot bot pushed a commit that referenced this pull request May 19, 2025
close #10163

Fix TiFlash crash due to invalid address alignment

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jun 12, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jun 13, 2025
close #10163

Fix TiFlash crash due to invalid address alignment

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
yongman added a commit to yongman/tiflash that referenced this pull request Jun 18, 2025
Signed-off-by: yongman <yming0221@gmail.com>
Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
bindsang pushed a commit to mengchengtech/tiflash that referenced this pull request Oct 11, 2025
close pingcap#10163

Fix TiFlash crash due to invalid address alignment

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TiFlash meet bus error and crash in some specific env

4 participants