Skip to content

[flash-867] add metrics for tmt#431

Merged
zanmato1984 merged 10 commits intomasterfrom
hanfei/tmt-metric
Feb 13, 2020
Merged

[flash-867] add metrics for tmt#431
zanmato1984 merged 10 commits intomasterfrom
hanfei/tmt-metric

Conversation

@hanfei1991
Copy link
Member

@hanfei1991 hanfei1991 commented Feb 11, 2020

following metrics is for read:

  • read index count
  • read parts count
  • (single) read index duration
  • (single) wait index duration

Every fail case is catched by Cop Metric so there is no need to consider failure here.
and following metrics is for write:

  • write parts count
  • write parts duration

and following metrics are for merge:

  • merge count
  • merge (total) duration

@hanfei1991
Copy link
Member Author

@zanmato1984 PTAL

@JaySon-Huang
Copy link
Contributor

/build

@hanfei1991
Copy link
Member Author

./rebuild

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991
Copy link
Member Author

/run-integration-tests

@hanfei1991
Copy link
Member Author

/rebuild

@zanmato1984 zanmato1984 merged commit 1f7f21c into master Feb 13, 2020
@zanmato1984 zanmato1984 deleted the hanfei/tmt-metric branch February 13, 2020 04:39
hanfei1991 added a commit that referenced this pull request Feb 13, 2020
* [flash-867] add metrics for tmt

* format and change

* address comments

* change some names of metric

* Refine help message

Co-authored-by: JaySon <jayson.hjs@gmail.com>
Co-authored-by: ruoxi <zanmato1984@gmail.com>
hanfei1991 added a commit that referenced this pull request Feb 13, 2020
* [flash-867] add metrics for tmt

* format and change

* address comments

* change some names of metric

* Refine help message

Co-authored-by: JaySon <jayson.hjs@gmail.com>
Co-authored-by: ruoxi <zanmato1984@gmail.com>

Co-authored-by: JaySon <jayson.hjs@gmail.com>
Co-authored-by: ruoxi <zanmato1984@gmail.com>
yongman added a commit to yongman/tiflash that referenced this pull request Jun 18, 2025
Signed-off-by: yongman <yming0221@gmail.com>
Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants