Skip to content

Fix address alignment error (#10175)#10183

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-10175-to-release-8.1
May 19, 2025
Merged

Fix address alignment error (#10175)#10183
ti-chi-bot[bot] merged 4 commits intopingcap:release-8.1from
ti-chi-bot:cherry-pick-10175-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10175

What problem does this PR solve?

Issue Number: close #10163

Problem Summary:

Ref to #10163

What is changed and how it works?

Use alignAlloc instead alloc to alloc memory for CachedColumnInfo

Fix TiFlash crash due to invalid address alignment

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

windtalker and others added 4 commits May 19, 2025 03:57
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 19, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2025
12 tasks
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-19 06:18:55.423390013 +0000 UTC m=+352701.679287407: ☑️ agreed by windtalker.
  • 2025-05-19 06:24:47.338539567 +0000 UTC m=+353053.594436966: ☑️ agreed by guo-shaoge.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 19, 2025
@ti-chi-bot ti-chi-bot bot merged commit eac52fd into pingcap:release-8.1 May 19, 2025
4 checks passed
bindsang pushed a commit to mengchengtech/tiflash that referenced this pull request Oct 11, 2025
close pingcap#10163

Fix TiFlash crash due to invalid address alignment

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: guo-shaoge <shaoge1994@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants