Specify extra store labels by param --labels#420
Merged
ti-chi-bot[bot] merged 5 commits intoraftstore-proxyfrom Feb 10, 2025
Merged
Specify extra store labels by param --labels#420ti-chi-bot[bot] merged 5 commits intoraftstore-proxyfrom
--labels#420ti-chi-bot[bot] merged 5 commits intoraftstore-proxyfrom
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Collaborator
Author
|
@CalvinNeo PTAL |
12 tasks
Signed-off-by: JaySon-Huang <tshent@qq.com>
CalvinNeo
reviewed
Feb 9, 2025
| .required(false) | ||
| .takes_value(true), | ||
| ) | ||
| .arg( |
Member
There was a problem hiding this comment.
Why not just keep it at the same place before print-sample-config? Clearer.
Collaborator
Author
There was a problem hiding this comment.
Because I want to keep the config items that affects store's label being put together. IMO, it's clearer than for later code reading.
CalvinNeo
reviewed
Feb 9, 2025
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
added a commit
that referenced
this pull request
Feb 11, 2025
ref pingcap/tiflash#9750 * Remove param `--engine-role-label` * Specify extra store labels by param `--labels` * If there are duplicated key in `server.labels` and `--labels`, use the one in `server.labels` Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
added a commit
that referenced
this pull request
Feb 11, 2025
ref pingcap/tiflash#9750 * Remove param `--engine-role-label` * Specify extra store labels by param `--labels` * If there are duplicated key in `server.labels` and `--labels`, use the one in `server.labels` Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
added a commit
that referenced
this pull request
Feb 11, 2025
ref pingcap/tiflash#9750 * Remove param `--engine-role-label` * Specify extra store labels by param `--labels` * If there are duplicated key in `server.labels` and `--labels`, use the one in `server.labels` Signed-off-by: JaySon-Huang <tshent@qq.com>
This was referenced Feb 11, 2025
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
…421) Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
added a commit
that referenced
this pull request
Feb 19, 2025
ref pingcap/tiflash#9750 * Remove param `--engine-role-label` * Specify extra store labels by param `--labels` * If there are duplicated key in `server.labels` and `--labels`, use the one in `server.labels` Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
added a commit
that referenced
this pull request
Feb 19, 2025
…422) * Specify extra store labels by param `--labels` (#420) ref pingcap/tiflash#9750 * Remove param `--engine-role-label` * Specify extra store labels by param `--labels` * If there are duplicated key in `server.labels` and `--labels`, use the one in `server.labels` Signed-off-by: JaySon-Huang <tshent@qq.com> Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> --------- Signed-off-by: JaySon-Huang <tshent@qq.com> Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Co-authored-by: Calvin Neo <calvinneo1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Ref pingcap/tiflash#9750
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note