Skip to content

Specify extra store labels by param --labels (#420) (release-8.5)#421

Merged
ti-chi-bot[bot] merged 1 commit intoraftstore-proxy-8.5from
set_extra_labels_85
Feb 13, 2025
Merged

Specify extra store labels by param --labels (#420) (release-8.5)#421
ti-chi-bot[bot] merged 1 commit intoraftstore-proxy-8.5from
set_extra_labels_85

Conversation

@JaySon-Huang
Copy link
Collaborator

@JaySon-Huang JaySon-Huang commented Feb 11, 2025 •
edited
Loading

cherry-pick of #420

ref pingcap/tiflash#9750

  • Remove param --engine-role-label
  • Specify extra store labels by param --labels
    • If there are duplicated key in server.labels and --labels, use the one in server.labels

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

@JaySon-Huang
Specify extra store labels by param --labels (#420)
cb442e1 
ref pingcap/tiflash#9750

* Remove param `--engine-role-label`
* Specify extra store labels by param `--labels`
  * If there are duplicated key in `server.labels` and `--labels`, use the one in `server.labels`

Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added the size/XL label Feb 11, 2025
@JaySon-Huang
Copy link
Collaborator Author

JaySon-Huang commented Feb 11, 2025

/test pull-unit-test

1 similar comment
@JaySon-Huang
Copy link
Collaborator Author

JaySon-Huang commented Feb 11, 2025

/test pull-unit-test

@JaySon-Huang
Copy link
Collaborator Author

JaySon-Huang commented Feb 11, 2025

/test build-check

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 11, 2025

@JaySon-Huang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-unit-test

Use /test all to run all jobs.

Details

In response to this:

/test build-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

CalvinNeo
CalvinNeo approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 13, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-13 05:41:22.131891554 +0000 UTC m=+507924.528113613: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 13, 2025
@ti-chi-bot ti-chi-bot bot merged commit c6be023 into raftstore-proxy-8.5 Feb 13, 2025
4 of 5 checks passed
@JaySon-Huang JaySon-Huang deleted the set_extra_labels_85 branch February 13, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees

No one assigned

Labels

approved lgtm size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JaySon-Huang @CalvinNeo