Specify extra store labels by param --labels (#420) (release-7.5)#423
Merged
JaySon-Huang merged 1 commit intoraftstore-proxy-7.5from Feb 19, 2025
Merged
Specify extra store labels by param --labels (#420) (release-7.5)#423JaySon-Huang merged 1 commit intoraftstore-proxy-7.5from
--labels (#420) (release-7.5)#423JaySon-Huang merged 1 commit intoraftstore-proxy-7.5from
Conversation
ref pingcap/tiflash#9750 * Remove param `--engine-role-label` * Specify extra store labels by param `--labels` * If there are duplicated key in `server.labels` and `--labels`, use the one in `server.labels` Signed-off-by: JaySon-Huang <tshent@qq.com>
Collaborator
Author
|
/test pull-unit-test |
|
@CalvinNeo: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CalvinNeo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of #420
ref pingcap/tiflash#9750
--engine-role-label--labelsserver.labelsand--labels, use the one inserver.labelsWhat is changed and how it works?
Issue Number: Close #xxx
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note