Skip to content

executor: flush statement should trigger implicit commit#34134

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
tiancaiamao:audit-log-flush
Apr 24, 2022
Merged

executor: flush statement should trigger implicit commit#34134
ti-chi-bot merged 3 commits intopingcap:masterfrom
tiancaiamao:audit-log-flush

Conversation

@tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Apr 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #34180
See https://github.com/pingcap/enterprise-plugin/issues/68

Problem Summary:

What is changed and how it works?

Let flush statement commit the current transaction.

begin;
delete from mysql.tidb_audit_table_access ...
flush tidb plugins audit;
commit;

After deleting the record from mysql.tidb_audit_table_access, the audit log plugin still working,
that's because flush tidb plugins audit; doen't see the uncommitted delete statement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Flush statement now trigger an implicit commit when called inside a transaction

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f9743a8faf69e6515f507fd61fc8c3e518af50aa

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 23, 2022
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Apr 24, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c55399b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2022
@tiancaiamao
Copy link
Contributor Author

tiancaiamao commented Apr 24, 2022

/merge

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 24, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-3.0
cb9f892 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-3.0 in PR #34182

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 24, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-2.1
388a423 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-2.1 in PR #34183

@ti-srebot ti-srebot mentioned this pull request Apr 24, 2022
Closed
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 24, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-4.0
10adfee 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-4.0 in PR #34184

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 24, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-5.0
52734fd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-5.0 in PR #34185

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 24, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-5.1
bc13f6c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-5.1 in PR #34186

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 24, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-5.2
20528c8 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-5.2 in PR #34187

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 24, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-5.3
6b85b5f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-5.3 in PR #34188

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 24, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-5.4
97ecbe0 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-5.4 in PR #34189

@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-3.1 failed

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 24, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-6.0
8bd4a69 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 24, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 24, 2022

cherry pick to release-6.0 in PR #34190

@sre-bot
Copy link
Contributor

sre-bot commented Apr 24, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 1, success 27, total 28 8 min 0 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 6 min 47 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

espresso98 pushed a commit to espresso98/tidb that referenced this pull request Apr 25, 2022
@tiancaiamao @espresso98
executor: flush statement should trigger implicit commit (pingcap#34134)
dc48849 
close pingcap#34180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngaut ngaut ngaut approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flush statement should trigger implicit commit

7 participants

@tiancaiamao @ti-chi-bot @sre-bot @ti-srebot @ngaut @lcwangchao @hawkingrei