Skip to content

executor: flush statement should trigger implicit commit (#34134)#34188

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.3from
ti-srebot:release-5.3-d3a02f416aaa
Closed

executor: flush statement should trigger implicit commit (#34134)#34188
ti-srebot wants to merge 1 commit intopingcap:release-5.3from
ti-srebot:release-5.3-d3a02f416aaa

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 24, 2022 •
edited
Loading

cherry-pick #34134 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/34188

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/34188:release-5.3-d3a02f416aaa

What problem does this PR solve?

Issue Number: close #34180
See https://github.com/pingcap/enterprise-plugin/issues/68

Problem Summary:

What is changed and how it works?

Let flush statement commit the current transaction.

begin;
delete from mysql.tidb_audit_table_access ...
flush tidb plugins audit;
commit;

After deleting the record from mysql.tidb_audit_table_access, the audit log plugin still working,
that's because flush tidb plugins audit; doen't see the uncommitted delete statement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Flush statement now trigger an implicit commit when called inside a transaction

@tiancaiamao @ti-srebot
cherry pick pingcap#34134 to release-5.3
6b85b5f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 24, 2022

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 24, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Apr 24, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 24, 2022
@ti-srebot ti-srebot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2022
@ti-srebot ti-srebot mentioned this pull request Apr 24, 2022
Merged
12 tasks
@ti-srebot ti-srebot added this to the v5.3.1 milestone Apr 24, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 24, 2022
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Apr 24, 2022

@tiancaiamao you're already a collaborator in bot's repo.

@VelocityLight
Copy link

VelocityLight commented Sep 16, 2022

This pull request is closed because the related issue is triaged "Won't Fix".
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 Awaiting requested review from bb7133

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

@ngaut ngaut Awaiting requested review from ngaut

Assignees

@tiancaiamao tiancaiamao

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.3-cherry-pick

Projects

None yet

Milestone

v5.3.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ti-chi-bot @VelocityLight @tiancaiamao