executor: flush statement should trigger implicit commit (#34134)#34182
Closed
ti-srebot wants to merge 1 commit intopingcap:release-3.0from
Closed
executor: flush statement should trigger implicit commit (#34134)#34182ti-srebot wants to merge 1 commit intopingcap:release-3.0from
ti-srebot wants to merge 1 commit intopingcap:release-3.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Member
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Contributor
Author
|
/run-all-tests |
12 tasks
Contributor
Author
|
@tiancaiamao you're already a collaborator in bot's repo. |
Member
|
close for DMR version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #34134 to release-3.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/34182After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #34180
See https://github.com/pingcap/enterprise-plugin/issues/68
Problem Summary:
What is changed and how it works?
Let flush statement commit the current transaction.
After deleting the record from
mysql.tidb_audit_table_access, the audit log plugin still working,that's because
flush tidb plugins audit;doen't see the uncommitteddeletestatement.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.