expression: change date add function return type by mengxin9014 · Pull Request #28133 · pingcap/tidb

mengxin9014 · 2021-09-17T03:50:36Z

What problem does this PR solve?

Issue Number: close #27573, close #36394

Problem Summary:
fix the bug that a string like "20129" will not be judged as date type
change date_add and date_sub string_(int/string/real/decimal) function return type to string

What is changed and how it works?

What's Changed:
time.go
expression/builtin_time.go
expression/builtin_time_test.go
expression/builtin_time_vec_generated.go
types/time_test.go
cmd/explaintest/r/tpch.result

How it Works:
if the length of a string with no separator is 5, it will be date type
if use date_add or date_sub string_(int/string/real/decimal) function will return string type

Check List

Tests

Unit test

Release note

change date_add and date_sub string_(int/string/real/decimal) function return type to string.

ti-chi-bot · 2021-09-17T03:50:38Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

windtalker
wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

mengxin9014 · 2021-09-17T04:25:20Z

/run-check_dev_2

mengxin9014 · 2021-09-17T07:18:20Z

/cc wjhuang2016

mengxin9014 · 2021-09-17T07:20:50Z

I change branch name to mx/changeDateAddFunctionReturnType, the original pr has closed(#27575)

mengxin9014 · 2021-09-17T07:52:11Z

/cc windtalker

wjhuang2016

It's a compatibility-breaker, I'm talking with PMs to decide what we should do.

mengxin9014 · 2021-12-17T06:09:33Z

/run-unit-test

sre-bot · 2021-12-17T06:22:26Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6b394825efc6ed636c1c4cb00a652e3a3f98a751

mengxin9014 · 2021-12-20T07:24:27Z

/run-check_dev_2

mengxin9014 · 2021-12-20T07:46:20Z

/run-check_dev_2

mengxin9014 · 2021-12-20T08:58:47Z

/run-check_dev_2

mengxin9014 · 2021-12-20T10:31:04Z

/run-check_dev_2

mengxin9014 · 2021-12-20T10:37:26Z

/run-check_dev_2

mengxin9014 · 2021-12-20T10:37:39Z

/run-check_dev_2

mengxin9014 · 2021-12-31T08:36:54Z

/run-check_dev_2

mengxin9014 · 2021-12-31T09:01:43Z

/run-unit-test

mengxin9014 · 2021-12-31T09:02:03Z

/run-mysql-test

mengxin9014 · 2021-12-31T09:09:23Z

/run-unit-test

mengxin9014 · 2021-12-31T09:35:29Z

/run-unit-test

mengxin9014 · 2021-12-31T09:35:57Z

/run-check_dev_2

mengxin9014 · 2021-12-31T09:40:43Z

/run-unit-test

mengxin9014 · 2021-12-31T10:01:01Z

/run-unit-test

mengxin9014 · 2021-12-31T10:18:21Z

/run-unit-test

mengxin9014 · 2021-12-31T10:45:08Z

/run-unit-test

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2021-12-31T11:02:34Z

cherry pick to release-5.4 in PR #31239

close #27573

* topsql: make topsql enable only be controlled by pub/sub sink (pingcap#31209) * ddl: support batch create table (pingcap#28763) * executor: fix data race in IndexMergeReaderExec (pingcap#31230) close pingcap#31229 * server: filter the EOF error for normal closed at handshake (pingcap#31081) close pingcap#31063 * expression: change date add function return type (pingcap#28133) close pingcap#27573 * support create interval partition Signed-off-by: crazycs520 <crazycs520@gmail.com> * support create interval partition (support int/timestamp partition key) Signed-off-by: crazycs520 <crazycs520@gmail.com> * parser: support alter table partitions move engine statement Signed-off-by: crazycs520 <crazycs520@gmail.com> * support ddl operation Signed-off-by: crazycs520 <crazycs520@gmail.com> * support interval partition manager Signed-off-by: crazycs520 <crazycs520@gmail.com> * support interval partition manager handle job framwork Signed-off-by: crazycs520 <crazycs520@gmail.com> * support auto create interval partition when insert meet no partition suitable error Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix bug Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix cancel job and load old job then continue to do Signed-off-by: crazycs520 <crazycs520@gmail.com> * make partition readonly work(not allow to insert/update/delete) Signed-off-by: crazycs520 <crazycs520@gmail.com> * add begin,end time in tables Signed-off-by: crazycs520 <crazycs520@gmail.com> * tiny fix for auto create interval partition in concurrent case Signed-off-by: crazycs520 <crazycs520@gmail.com> * init Signed-off-by: crazycs520 <crazycs520@gmail.com> * init Signed-off-by: crazycs520 <crazycs520@gmail.com> * todo: remove flag Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix dumpling Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove data in aws s3 when drop/truncate table/partition Signed-off-by: crazycs520 <crazycs520@gmail.com> * make hello world work Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove debug info Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: xhe <xw897002528@gmail.com> Co-authored-by: guo-shaoge <shaoge1994@163.com> Co-authored-by: knull-cn <hu__haifeng@163.com> Co-authored-by: Meng Xin <tregoldmeng@gmail.com>

ti-chi-bot · 2022-11-04T06:27:45Z

In response to a cherrypick label: new pull request created: #38889.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

close #27573

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 17, 2021

ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 17, 2021

mengxin9014 marked this pull request as draft September 17, 2021 07:03

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2021

mengxin9014 marked this pull request as ready for review September 17, 2021 07:08

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2021

ti-chi-bot requested a review from wjhuang2016 September 17, 2021 07:18

ti-chi-bot requested a review from windtalker September 17, 2021 07:52

wjhuang2016 reviewed Sep 17, 2021

View reviewed changes

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2021

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2021

mengxin9014 marked this pull request as draft December 17, 2021 06:23

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2021

mengxin9014 marked this pull request as ready for review December 20, 2021 06:47

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2021

Merge branch 'master' into mx/changeDateAddFunctionReturnType

e3f52f7

Merge branch 'master' into mx/changeDateAddFunctionReturnType

0bedc21

Merge branch 'master' into mx/changeDateAddFunctionReturnType

5cb087c

wjhuang2016 added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Dec 31, 2021

Merge branch 'master' into mx/changeDateAddFunctionReturnType

5166043

Merge branch 'master' into mx/changeDateAddFunctionReturnType

6b39482

ti-chi-bot merged commit 5ea64e6 into pingcap:master Dec 31, 2021

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 31, 2021

cherry pick pingcap#28133 to release-5.4

6148af4

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Dec 31, 2021

expression: change date add function return type (#28133) #31239

Merged

1 task

ti-chi-bot pushed a commit that referenced this pull request Jan 4, 2022

expression: change date add function return type (#28133) (#31239)

855f58b

close #27573

windtalker mentioned this pull request Jan 7, 2022

expression: change date add function return type #31215

Closed

1 task

windtalker mentioned this pull request May 21, 2022

Scalar function date_add(signature: ScalarFuncSig_AddDateStringInt) has different behaviour between TiDB and TiFlash. #27336

Closed

tangenta mentioned this pull request Jul 29, 2022

Function adddate() returns unexpected when connect with jdbc driver #36394

Closed

Defined2014 added the needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 label Nov 4, 2022

ti-chi-bot mentioned this pull request Nov 4, 2022

expression: change date add function return type (#28133) #38889

Merged

1 task

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Nov 4, 2022

This is an automated cherry-pick of pingcap#28133

4ca8802

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot added a commit that referenced this pull request Nov 4, 2022

expression: change date add function return type (#28133) (#38889)

a24aea5

close #27573

Conversation

mengxin9014 commented Sep 17, 2021 • edited by Defined2014 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Sep 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mengxin9014 commented Sep 17, 2021

Uh oh!

mengxin9014 commented Sep 17, 2021

Uh oh!

mengxin9014 commented Sep 17, 2021

Uh oh!

mengxin9014 commented Sep 17, 2021

Uh oh!

wjhuang2016 left a comment

Choose a reason for hiding this comment

Uh oh!

mengxin9014 commented Dec 17, 2021

Uh oh!

sre-bot commented Dec 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mengxin9014 commented Dec 20, 2021

Uh oh!

mengxin9014 commented Dec 20, 2021

Uh oh!

mengxin9014 commented Dec 20, 2021

Uh oh!

mengxin9014 commented Dec 20, 2021

Uh oh!

mengxin9014 commented Dec 20, 2021

Uh oh!

mengxin9014 commented Dec 20, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

mengxin9014 commented Dec 31, 2021

Uh oh!

ti-srebot commented Dec 31, 2021

Uh oh!

ti-chi-bot commented Nov 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mengxin9014 commented Sep 17, 2021 •

edited by Defined2014

Loading

ti-chi-bot commented Sep 17, 2021 •

edited

Loading

sre-bot commented Dec 17, 2021 •

edited

Loading