WIP:types: fix isDateFormat function bugs#27575
Closed
mengxin9014 wants to merge 18 commits intopingcap:masterfrom
Closed
WIP:types: fix isDateFormat function bugs#27575mengxin9014 wants to merge 18 commits intopingcap:masterfrom
mengxin9014 wants to merge 18 commits intopingcap:masterfrom
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Contributor
Author
|
/run-all-tests |
wjhuang2016
reviewed
Aug 25, 2021
Member
wjhuang2016
left a comment
There was a problem hiding this comment.
The returning type is wrong.
TiDB:
mysql> select DATE_ADD(a, INTERVAL 1 day ) from t ;
Field 1: `DATE_ADD(a, INTERVAL 1 day )`
Catalog: `def`
Database: ``
Table: ``
Org_table: ``
Type: DATETIME
Collation: binary (63)
Length: 29
Max_length: 19
Decimals: 31
Flags: NOT_NULL BINARY
+------------------------------+
| DATE_ADD(a, INTERVAL 1 day ) |
+------------------------------+
| 2020-12-10 00:00:00 |
+------------------------------+
1 row in set (0.00 sec)
MySQL:
mysql> select DATE_ADD(a, INTERVAL 1 day ) from t ;
Field 1: `DATE_ADD(a, INTERVAL 1 day )`
Catalog: `def`
Database: ``
Table: ``
Org_table: ``
Type: STRING
Collation: utf8mb4_0900_ai_ci (255)
Length: 116
Max_length: 10
Decimals: 31
Flags:
+------------------------------+
| DATE_ADD(a, INTERVAL 1 day ) |
+------------------------------+
| 2020-12-10 |
+------------------------------+
1 row in set (0.01 sec)
…nto dev/fixIsDateFormatBug
…into dev/fixIsDateFormatBug
Contributor
Author
|
/run-check_dev_2 |
Contributor
Author
|
/run-check_dev_2 |
3 similar comments
Contributor
Author
|
/run-check_dev_2 |
Contributor
Author
|
/run-check_dev_2 |
Contributor
Author
|
/run-check_dev_2 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #27573
Problem Summary:
fix the bug that a string like "20129" will not be judged as date type
change date_add and date_sub string_(int/string/real/decimal) function return type to string
What is changed and how it works?
Proposal: xxx
What's Changed:
time.go
expression/builtin_time.go
expression/builtin_time_test.go
expression/builtin_time_vec_generated.go
types/time_test.go
cmd/explaintest/r/tpch.result
How it Works:
if the length of a string with no separator is 5, it will be date type
if use date_add or date_sub string_(int/string/real/decimal) function will return string type
Check List
Tests
Release note