server: filter the EOF error for normal closed at handshake by knull-cn · Pull Request #31081 · pingcap/tidb

knull-cn · 2021-12-28T08:29:39Z

What problem does this PR solve?

Issue Number: close #31063

Problem Summary: loader balance (eg: gcp lb )check health : construct tcp link ok and closed before handshake , tidb will print error log for EOF.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
- run tcp client -- remember change the ip/port of tidb
  - tcp client test code was show latter
- at tidb.log , you will see the EOF at debug level log and see other errors info in error level log
No code

# `tcp client` test code
#!/usr/bin/env python    
import socket    
    
TCP_IP = '127.0.0.1'    
TCP_PORT = 4000    
BUFFER_SIZE = 1024    
MESSAGE = ""    
s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)    
s.connect((TCP_IP, TCP_PORT))    
s.close()

Release note

None

ti-chi-bot · 2021-12-28T08:29:40Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

djshow832
jackysp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

sre-bot · 2021-12-28T08:31:08Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

*: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

sre-bot · 2021-12-28T08:47:50Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/0c89d9e6023392ffbe93945e2d83d5f5a0a58b06

bb7133 · 2021-12-29T02:27:48Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what is changed
Or if the count of mainly changed packages are more than 3, use

*: what is changed
After you have format title, you can leave a comment /run-check_title to recheck it

@knull-cn Please fix the title check.

bb7133 · 2021-12-29T02:28:27Z

/run-check_dev_2

server/server.go

bb7133 · 2021-12-29T02:30:35Z

Please add a test case for your change, thanks!

sre-bot · 2021-12-29T02:55:24Z

Please follow PR Title Format:

pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

*: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

knull-cn · 2021-12-29T03:30:07Z

/run-check_title

server/server.go

knull-cn · 2021-12-29T04:25:51Z

/run-unit-test

server/server.go

knull-cn · 2021-12-29T11:19:27Z

/run-check_dev_2

knull-cn · 2021-12-29T12:02:16Z

/run-check_dev_2

djshow832 · 2021-12-30T12:30:28Z

Please add a test case for your change, thanks!

I think it's fine to only add a manual test because it only touches the logs.

lichunzhu · 2021-12-31T03:02:26Z

/run-mysql-test

knull-cn · 2021-12-31T03:02:41Z

/run-mysql-test

jackysp

LGTM

jackysp · 2021-12-31T05:40:22Z

/merge

ti-chi-bot · 2021-12-31T05:40:25Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: b6373e0

knull-cn · 2021-12-31T06:07:12Z

/run-check_dev_2

knull-cn · 2021-12-31T06:07:23Z

/run_unit-test

knull-cn · 2021-12-31T07:03:11Z

/run-unit-test

knull-cn · 2021-12-31T10:09:24Z

/run-check_dev2

knull-cn · 2021-12-31T10:15:11Z

/run-mysql-test

* topsql: make topsql enable only be controlled by pub/sub sink (pingcap#31209) * ddl: support batch create table (pingcap#28763) * executor: fix data race in IndexMergeReaderExec (pingcap#31230) close pingcap#31229 * server: filter the EOF error for normal closed at handshake (pingcap#31081) close pingcap#31063 * expression: change date add function return type (pingcap#28133) close pingcap#27573 * support create interval partition Signed-off-by: crazycs520 <crazycs520@gmail.com> * support create interval partition (support int/timestamp partition key) Signed-off-by: crazycs520 <crazycs520@gmail.com> * parser: support alter table partitions move engine statement Signed-off-by: crazycs520 <crazycs520@gmail.com> * support ddl operation Signed-off-by: crazycs520 <crazycs520@gmail.com> * support interval partition manager Signed-off-by: crazycs520 <crazycs520@gmail.com> * support interval partition manager handle job framwork Signed-off-by: crazycs520 <crazycs520@gmail.com> * support auto create interval partition when insert meet no partition suitable error Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix bug Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix cancel job and load old job then continue to do Signed-off-by: crazycs520 <crazycs520@gmail.com> * make partition readonly work(not allow to insert/update/delete) Signed-off-by: crazycs520 <crazycs520@gmail.com> * add begin,end time in tables Signed-off-by: crazycs520 <crazycs520@gmail.com> * tiny fix for auto create interval partition in concurrent case Signed-off-by: crazycs520 <crazycs520@gmail.com> * init Signed-off-by: crazycs520 <crazycs520@gmail.com> * init Signed-off-by: crazycs520 <crazycs520@gmail.com> * todo: remove flag Signed-off-by: crazycs520 <crazycs520@gmail.com> * fix dumpling Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove data in aws s3 when drop/truncate table/partition Signed-off-by: crazycs520 <crazycs520@gmail.com> * make hello world work Signed-off-by: crazycs520 <crazycs520@gmail.com> * remove debug info Signed-off-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: xhe <xw897002528@gmail.com> Co-authored-by: guo-shaoge <shaoge1994@163.com> Co-authored-by: knull-cn <hu__haifeng@163.com> Co-authored-by: Meng Xin <tregoldmeng@gmail.com>

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2022-03-30T07:37:26Z

cherry pick to release-5.4 in PR #33589

…31081) close pingcap#31063

…46866) close #31063

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 28, 2021

bb7133 reviewed Dec 29, 2021

View reviewed changes

server/server.go Outdated Show resolved Hide resolved

knull-cn added 2 commits December 29, 2021 10:51

fix the error log ,filter the EOF error for normal closed.

16687db

Merge branch 'master' of github.com:pingcap/tidb into kdev

e98b03a

knull-cn force-pushed the kdev branch from bd338b3 to e98b03a Compare December 29, 2021 02:53

knull-cn changed the title ~~fix the error log ,filter the EOF error for normal closed.~~ server : fix the error log ,filter the EOF error for normal closed. Dec 29, 2021

knull-cn changed the title ~~server : fix the error log ,filter the EOF error for normal closed.~~ server: fix the error log ,filter the EOF error for normal closed. Dec 29, 2021

knull-cn changed the title ~~server: fix the error log ,filter the EOF error for normal closed.~~ server: fix the error log ,filter the EOF error for normal closed Dec 29, 2021

knull-cn changed the title ~~server: fix the error log ,filter the EOF error for normal closed~~ server: filter the EOF error for normal closed at handshake Dec 29, 2021

knull-cn commented Dec 29, 2021

View reviewed changes

server/server.go Show resolved Hide resolved

jackysp added the type/enhancement The issue or PR belongs to an enhancement. label Dec 29, 2021

jackysp reviewed Dec 29, 2021

View reviewed changes

server/server.go Outdated Show resolved Hide resolved

jackysp reviewed Dec 29, 2021

View reviewed changes

server/server.go Show resolved Hide resolved

Warn is enough,change level from 'Error' to 'Warn'

b6373e0

djshow832 approved these changes Dec 30, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2021

jackysp approved these changes Dec 31, 2021

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 31, 2021

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 31, 2021

Merge branch 'master' into kdev

0e8b0c6

Merge branch 'master' into kdev

2dd70cf

Merge branch 'master' into kdev

671f184

Merge branch 'master' into kdev

0c89d9e

ti-chi-bot merged commit 45879b5 into pingcap:master Dec 31, 2021

DanielZhangQD mentioned this pull request Jan 7, 2022

tidb error pingcap/tidb-operator#4351

Closed

knull-cn deleted the kdev branch February 22, 2022 01:58

jackysp added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Mar 30, 2022

ti-srebot mentioned this pull request Mar 30, 2022

server: filter the EOF error for normal closed at handshake (#31081) #33589

Closed

4 tasks

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2022

cherry pick pingcap#31081 to release-5.4

697fe45

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

elsa0520 pushed a commit to elsa0520/tidb that referenced this pull request Sep 11, 2023

server: filter the EOF error for normal closed at handshake (pingcap#…

4a4e7e9

…31081) close pingcap#31063

elsa0520 mentioned this pull request Sep 11, 2023

server: filter the EOF error for normal closed at handshake (#31081) #46866

Merged

12 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Sep 11, 2023

server: filter the EOF error for normal closed at handshake (#31081) (#…

783639f

…46866) close #31063

Conversation

knull-cn commented Dec 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Dec 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sre-bot commented Dec 28, 2021

Uh oh!

sre-bot commented Dec 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bb7133 commented Dec 29, 2021

Uh oh!

bb7133 commented Dec 29, 2021

Uh oh!

Uh oh!

bb7133 commented Dec 29, 2021

Uh oh!

sre-bot commented Dec 29, 2021

Uh oh!

knull-cn commented Dec 29, 2021

Uh oh!

Uh oh!

knull-cn commented Dec 29, 2021

Uh oh!

Uh oh!

Uh oh!

knull-cn commented Dec 29, 2021

Uh oh!

knull-cn commented Dec 29, 2021

Uh oh!

djshow832 commented Dec 30, 2021

Uh oh!

lichunzhu commented Dec 31, 2021

Uh oh!

knull-cn commented Dec 31, 2021

Uh oh!

jackysp left a comment

Choose a reason for hiding this comment

Uh oh!

jackysp commented Dec 31, 2021

Uh oh!

ti-chi-bot commented Dec 31, 2021

Uh oh!

knull-cn commented Dec 31, 2021

Uh oh!

knull-cn commented Dec 31, 2021

Uh oh!

knull-cn commented Dec 31, 2021

Uh oh!

knull-cn commented Dec 31, 2021

Uh oh!

knull-cn commented Dec 31, 2021

Uh oh!

ti-srebot commented Mar 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

knull-cn commented Dec 28, 2021 •

edited

Loading

ti-chi-bot commented Dec 28, 2021 •

edited

Loading

sre-bot commented Dec 28, 2021 •

edited

Loading