Skip to content

expression: push down mod() to TiFlash (#26494)#27865

Merged
ti-chi-bot merged 4 commits intopingcap:release-5.1from
ti-srebot:release-5.1-e116573fbb94
Sep 15, 2021
Merged

expression: push down mod() to TiFlash (#26494)#27865
ti-chi-bot merged 4 commits intopingcap:release-5.1from
ti-srebot:release-5.1-e116573fbb94

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 7, 2021 •
edited
Loading

cherry-pick #26494 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/27865

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/27865:release-5.1-e116573fbb94

What problem does this PR solve?

Issue Number: close pingcap/tiflash#2318

Problem Summary:

What is changed and how it work

What's Changed: push down mod() to TiFlash.

How it Works:

Release note

  • push down mod() to TiFlash.

@riteme @ti-srebot
cherry pick pingcap#26494 to release-5.1
d26a904 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2021

@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 7, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Sep 7, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2021
Merged
@ti-srebot ti-srebot added component/expression size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.1-cherry-pick labels Sep 7, 2021
@ti-srebot ti-srebot requested a review from rebelice September 7, 2021 12:47
@ti-srebot ti-srebot added this to the v5.1.1 milestone Sep 7, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Sep 7, 2021

@riteme please accept the invitation then you can push to the cherry-pick pull requests. Comment with /cherry-pick-invite if the invitation is expired.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2021
@qw4990
Copy link
Contributor

qw4990 commented Sep 7, 2021

PTAL @rebelice

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 14, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2021
@Reminiscent
Copy link
Contributor

Reminiscent commented Sep 15, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d26a904

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2021
@zhouqiang-cl zhouqiang-cl removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 15, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d4cd12f into pingcap:release-5.1 Sep 15, 2021
windtalker added a commit to windtalker/tidb that referenced this pull request Sep 16, 2021
@windtalker
Revert "expression: push down mod() to TiFlash (pingcap#26494) (pingc…
c1a3558 
…ap#27865)"

This reverts commit d4cd12f.
ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@windtalker
Revert "expression: push down mod() to TiFlash (#26494) (#27865)" (#2…
3c49716 
…8091)
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.1.1, v5.0.4, v5.1.2 Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

@rebelice rebelice rebelice approved these changes

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. component/expression size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick

Projects

None yet

Milestone

v5.1.2

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-srebot @ti-chi-bot @qw4990 @Reminiscent @rebelice @zhouqiang-cl @riteme