Skip to content

expression: push down mod() to TiFlash#26494

Merged
ti-chi-bot merged 18 commits intopingcap:masterfrom
riteme:tiflash-function-mod
Jul 27, 2021
Merged

expression: push down mod() to TiFlash#26494
ti-chi-bot merged 18 commits intopingcap:masterfrom
riteme:tiflash-function-mod

Conversation

@riteme
Copy link
Contributor

@riteme riteme commented Jul 23, 2021

What problem does this PR solve?

Issue Number: close pingcap/tiflash#2318

Problem Summary:

What is changed and how it work

What's Changed: push down mod() to TiFlash.

How it Works:

Release note

  • push down mod() to TiFlash.

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2021
leiysky
leiysky approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
@riteme
Copy link
Contributor Author

riteme commented Jul 23, 2021

/run-check_dev_2

@leiysky leiysky mentioned this pull request Jul 23, 2021
Closed
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2021
@riteme
Copy link
Contributor Author

riteme commented Jul 26, 2021

/run-check_dev_2

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • leiysky
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2021
@fuzhe1989
Copy link
Contributor

fuzhe1989 commented Jul 27, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021

@fuzhe1989: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@leiysky
Copy link
Contributor

leiysky commented Jul 27, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b813488

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 27, 2021
@ti-chi-bot ti-chi-bot merged commit e116573 into pingcap:master Jul 27, 2021
@qw4990
Copy link
Contributor

qw4990 commented Sep 7, 2021

/cherry-pick release-5.1

@qw4990
Copy link
Contributor

qw4990 commented Sep 7, 2021

/cherry-pick release-5.2

@ti-srebot ti-srebot mentioned this pull request Sep 7, 2021
Merged
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 7, 2021
@riteme @ti-srebot
cherry pick pingcap#26494 to release-5.1
d26a904 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 7, 2021

cherry pick to release-5.1 in PR #27865

@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 7, 2021

cherry pick to release-5.2 failed

ti-chi-bot pushed a commit that referenced this pull request Sep 15, 2021
@ti-srebot
expression: push down mod() to TiFlash (#26494) (#27865)
d4cd12f
windtalker added a commit to windtalker/tidb that referenced this pull request Sep 16, 2021
@windtalker
Revert "expression: push down mod() to TiFlash (pingcap#26494) (pingc…
c1a3558 
…ap#27865)"

This reverts commit d4cd12f.
ti-chi-bot pushed a commit that referenced this pull request Sep 16, 2021
@windtalker
Revert "expression: push down mod() to TiFlash (#26494) (#27865)" (#2…
3c49716 
…8091)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebelice rebelice rebelice approved these changes

+1 more reviewer

@leiysky leiysky leiysky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/expression needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support function mod in TiFlash

8 participants

@riteme @CLAassistant @ti-chi-bot @fuzhe1989 @leiysky @qw4990 @ti-srebot @rebelice