Skip to content

Revert "expression: push down mod() to TiFlash (#26494) (#27865)"#28091

Merged
ti-chi-bot merged 11 commits intopingcap:release-5.1from
windtalker:release-5.1
Sep 16, 2021
Merged

Revert "expression: push down mod() to TiFlash (#26494) (#27865)"#28091
ti-chi-bot merged 11 commits intopingcap:release-5.1from
windtalker:release-5.1

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Sep 16, 2021 •
edited
Loading

This reverts commit d4cd12f.

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

This reverts commit d4cd12fe422fb18b6012607ee18b6acca40d9225.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fzhedu
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 16, 2021
fzhedu
fzhedu approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 16, 2021
@windtalker
Copy link
Contributor Author

windtalker commented Sep 16, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2021

@windtalker: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@rebelice
Copy link
Contributor

rebelice commented Sep 16, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c1a3558

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 16, 2021
@windtalker
Copy link
Contributor Author

windtalker commented Sep 16, 2021

/run-check_dev

@windtalker
Copy link
Contributor Author

windtalker commented Sep 16, 2021

/run-check_dev

@windtalker
Copy link
Contributor Author

windtalker commented Sep 16, 2021

/run-check_dev

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Sep 16, 2021

/merge

@zhouqiang-cl
Copy link
Contributor

zhouqiang-cl commented Sep 16, 2021

@ti-chi-bot

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 16, 2021

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3c49716 into pingcap:release-5.1 Sep 16, 2021
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.1.1, v5.1.2 Sep 18, 2021
@qiancai qiancai mentioned this pull request Sep 26, 2021
Merged
13 tasks
@windtalker windtalker deleted the release-5.1 branch October 23, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebelice rebelice rebelice approved these changes

+1 more reviewer

@fzhedu fzhedu fzhedu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

v5.1.2

Development

Successfully merging this pull request may close these issues.

5 participants

@windtalker @ti-chi-bot @rebelice @zhouqiang-cl @fzhedu