Skip to content

executor: fix 'index out of range' issue in index lookup join#23755

Merged
ti-chi-bot merged 11 commits intopingcap:masterfrom
tangenta:clustered-index-fix-idxlookup-join
Mar 31, 2021
Merged

executor: fix 'index out of range' issue in index lookup join#23755
ti-chi-bot merged 11 commits intopingcap:masterfrom
tangenta:clustered-index-fix-idxlookup-join

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Mar 31, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #23722

What is changed and how it works?

What's Changed: Update the truncate logic in constructLookupContent.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

NA

Release note

  • No release note

@tangenta tangenta requested a review from a team as a code owner March 31, 2021 11:28
@tangenta tangenta requested review from qw4990 and removed request for a team March 31, 2021 11:28
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2021
@tangenta
Copy link
Contributor Author

tangenta commented Mar 31, 2021

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Mar 31, 2021
@tangenta tangenta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2021
@tangenta tangenta changed the title executor: fix index lookup join on clustered index executor: fix 'index out of range' issue in index lookup join Mar 31, 2021
@wjhuang2016
Copy link
Member

wjhuang2016 commented Mar 31, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2021
@tangenta
Copy link
Contributor Author

tangenta commented Mar 31, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2021

@tangenta: /merge is only allowed for the committers in list.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zz-jason
Copy link
Member

zz-jason commented Mar 31, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: da9cc1b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2021
@ti-chi-bot ti-chi-bot merged commit 5dab3f9 into pingcap:master Mar 31, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 31, 2021
@ti-srebot
cherry pick pingcap#23755 to release-5.0
bdff6d6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 31, 2021
Merged
@ti-srebot
Copy link
Contributor

ti-srebot commented Mar 31, 2021

cherry pick to release-5.0 in PR #23780

ti-chi-bot pushed a commit that referenced this pull request Apr 1, 2021
@ti-srebot
executor: fix 'index out of range' issue in index lookup join (#23755) (
70c00fb 
#23780)
@zyguan zyguan mentioned this pull request Apr 10, 2021
Closed
lzmhhh123 pushed a commit to lzmhhh123/tidb that referenced this pull request Oct 29, 2021
@tangenta @lzmhhh123
executor: fix 'index out of range' issue in index lookup join (pingca…
6a4eb7e 
…p#23755)
lzmhhh123 pushed a commit to lzmhhh123/tidb that referenced this pull request Oct 29, 2021
@tangenta @lzmhhh123
executor: fix 'index out of range' issue in index lookup join (pingca…
345bdac 
…p#23755)
zhouqiang-cl pushed a commit that referenced this pull request Oct 29, 2021
@lzmhhh123
executor: fix 'index out of range' issue in index lookup join (#23755) (
0a57901 
#29250)

* executor: fix 'index out of range' issue in index lookup join (#23755)

Signed-off-by: lzmhhh123 <lzmhhh123@gmail.com>
@ti-srebot ti-srebot mentioned this pull request Nov 8, 2021
Closed
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Nov 8, 2021
@ti-srebot
cherry pick pingcap#23755 to release-4.0
a37f336 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

ti-srebot commented Nov 8, 2021

cherry pick to release-4.0 in PR #29550

lzmhhh123 pushed a commit to ti-srebot/tidb that referenced this pull request Nov 18, 2021
@lzmhhh123
executor: fix 'index out of range' issue in index lookup join (pingca…
9ceaa83 
…p#23755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 qw4990 approved these changes

Assignees

No one assigned

Labels

needs-cherry-pick-release-5.0 sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

index out of range on innerWorker of index lookup join when clustered index enabled

7 participants

@tangenta @wjhuang2016 @ti-chi-bot @zz-jason @ti-srebot @qw4990 @zimulala