Skip to content

executor: fix 'index out of range' issue in index lookup join (#23755)#23780

Merged
ti-chi-bot merged 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-5dab3f95bf15
Apr 1, 2021
Merged

executor: fix 'index out of range' issue in index lookup join (#23755)#23780
ti-chi-bot merged 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-5dab3f95bf15

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 31, 2021 •
edited
Loading

cherry-pick #23755 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23780

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/23780:release-5.0-5dab3f95bf15

What problem does this PR solve?

Issue Number: close #23722

What is changed and how it works?

What's Changed: Update the truncate logic in constructLookupContent.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

NA

Release note

  • No release note

@ti-srebot
cherry pick pingcap#23755 to release-5.0
bdff6d6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner March 31, 2021 20:32
@ti-srebot ti-srebot requested review from wshwsh12 and removed request for a team March 31, 2021 20:32
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Mar 31, 2021

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Mar 31, 2021
Merged
@ti-srebot ti-srebot added sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.0-cherry-pick labels Mar 31, 2021
@ti-srebot ti-srebot requested a review from qw4990 March 31, 2021 20:32
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Mar 31, 2021
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Mar 31, 2021

@tangenta you're already a collaborator in bot's repo.

Reminiscent
Reminiscent approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2021

@Reminiscent: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2021
wshwsh12
wshwsh12 approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 1, 2021
@qw4990
Copy link
Contributor

qw4990 commented Apr 1, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: bdff6d6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 1, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 1, 2021
@ti-chi-bot ti-chi-bot merged commit 70c00fb into pingcap:release-5.0 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

+1 more reviewer

@Reminiscent Reminiscent Reminiscent approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tangenta tangenta

Labels

cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick

Projects

None yet

Milestone

v5.0.0 ga

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-srebot @ti-chi-bot @qw4990 @wshwsh12 @Reminiscent @zhouqiang-cl @tangenta