Skip to content

executor: fix 'index out of range' issue in index lookup join (#23755)#29550

Closed
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-5dab3f95bf15
Closed

executor: fix 'index out of range' issue in index lookup join (#23755)#29550
ti-srebot wants to merge 1 commit intopingcap:release-4.0from
ti-srebot:release-4.0-5dab3f95bf15

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 8, 2021 •
edited
Loading

cherry-pick #23755 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/29550

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/29550:release-4.0-5dab3f95bf15

What problem does this PR solve?

Issue Number: close #23722

What is changed and how it works?

What's Changed: Update the truncate logic in constructLookupContent.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

NA

Release note

  • No release note

@ti-srebot
cherry pick pingcap#23755 to release-4.0
a37f336 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021

@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 8, 2021

/run-all-tests

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021

@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Nov 8, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 8, 2021
Merged
@ti-srebot ti-srebot added sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/4.0-cherry-pick labels Nov 8, 2021
@ti-srebot ti-srebot requested a review from qw4990 November 8, 2021 06:59
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Nov 8, 2021

@tangenta you're already a collaborator in bot's repo.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2021

@ti-srebot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021
@xhebox
Copy link
Contributor

xhebox commented Aug 30, 2022

close for DMR version

@xhebox xhebox closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees

@tangenta tangenta

Labels

do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/4.0-cherry-pick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-srebot @ti-chi-bot @xhebox @tangenta