util, types: don't let SPM be affected by charset#23161
Merged
XuHuaiyu merged 26 commits intopingcap:masterfrom Mar 12, 2021
Merged
util, types: don't let SPM be affected by charset#23161XuHuaiyu merged 26 commits intopingcap:masterfrom
XuHuaiyu merged 26 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
/run-check_dev_2 parser=pr/1184 |
Contributor
Author
|
/rebuild parser=pr/1184 |
Contributor
Author
Contributor
Author
|
/sig planner |
Contributor
Author
|
/cc @qw4990 |
Contributor
Author
|
/cc @eurekaka |
eurekaka
reviewed
Mar 12, 2021
Contributor
eurekaka
left a comment
There was a problem hiding this comment.
Please add test for this PR.
eurekaka
reviewed
Mar 12, 2021
Member
|
Merge canceled because a new commit is pushed. |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
1 similar comment
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
XuHuaiyu
reviewed
Mar 12, 2021
session/bootstrap_test.go
Outdated
| bindCase.bindText, | ||
| bindCase.db, | ||
| ) | ||
| fmt.Println("[sql]", sql) |
session/bootstrap.go
Outdated
| upgradeToVer59, | ||
| upgradeToVer60, | ||
| upgradeToVer61, | ||
| // We will redo upgradeToVer61 in upgradeToVer6, it is skipped here. |
Contributor
Author
|
/run-all-tests |
Contributor
|
/lgtm |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Mar 12, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
cherry pick to release-4.0 in PR #23295 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Different default charsets in different drivers(or versions) make SQL bind cannot work.
So we don't let SPM be affected by charset.
We add a flag
RestoreStringWithoutCharsetto control this.Need to merge parser pr first
Related changes
Check List
Tests
Side effects
Release note