Skip to content

format: add RestoreStringWithoutCharset flag#1184

Merged
kennytm merged 2 commits intopingcap:masterfrom
rebelice:dev_remove_charset
Mar 10, 2021
Merged

format: add RestoreStringWithoutCharset flag#1184
kennytm merged 2 commits intopingcap:masterfrom
rebelice:dev_remove_charset

Conversation

@rebelice
Copy link
Contributor

@rebelice rebelice commented Mar 8, 2021

What problem does this PR solve?

Add RestoreStringWithoutCharset flag
This is used in tidb pr

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@rebelice
Copy link
Contributor Author

rebelice commented Mar 8, 2021

/cc @qw4990, @eurekaka

@ti-srebot ti-srebot requested review from eurekaka and qw4990 March 8, 2021 06:30
@ti-srebot ti-srebot added the status/LGT1 LGT1 label Mar 9, 2021
@kennytm
Copy link
Contributor

kennytm commented Mar 10, 2021

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Mar 10, 2021
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Mar 10, 2021
@kennytm
Copy link
Contributor

kennytm commented Mar 10, 2021

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@kennytm kennytm merged commit c7333a4 into pingcap:master Mar 10, 2021
rebelice added a commit to rebelice/parser that referenced this pull request Apr 21, 2021
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
kennytm pushed a commit that referenced this pull request Apr 21, 2021
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants