Skip to content

format: add RestoreStringWithoutCharset flag (#1184)#1213

Merged
kennytm merged 1 commit intopingcap:release-4.0from
rebelice:cherry-pick_remove_charset
Apr 21, 2021
Merged

format: add RestoreStringWithoutCharset flag (#1184)#1213
kennytm merged 1 commit intopingcap:release-4.0from
rebelice:cherry-pick_remove_charset

Conversation

@rebelice
Copy link
Contributor

Co-authored-by: ti-srebot 66930949+ti-srebot@users.noreply.github.com

What problem does this PR solve?

Cherry-pick #1184 to branch 4.0

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
@rebelice
Copy link
Contributor Author

/cc @xiongjiwei

@ti-srebot ti-srebot requested a review from xiongjiwei April 21, 2021 11:31
@rebelice
Copy link
Contributor Author

/cc @kennytm

@ti-srebot ti-srebot requested a review from kennytm April 21, 2021 11:32
@ti-srebot ti-srebot added the status/LGT1 LGT1 label Apr 21, 2021
@kennytm
Copy link
Contributor

kennytm commented Apr 21, 2021

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Apr 21, 2021
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Apr 21, 2021
@kennytm kennytm merged commit 451a84c into pingcap:release-4.0 Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants