util, types: don't let SPM be affected by charset (#23161)#23295
util, types: don't let SPM be affected by charset (#23161)#23295ti-chi-bot merged 18 commits intopingcap:release-4.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
@rebelice you're already a collaborator in bot's repo. |
|
/merge |
|
@zhouqiang-cl: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
session/bootstrap.go
Outdated
|
|
||
| func upgradeToVer51(s Session, ver int64) { | ||
| if ver >= version51 { | ||
| if ver >= version52 { |
There was a problem hiding this comment.
Why not version51 here? Rest LGTM
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 190c6b2 |
lzmhhh123
left a comment
There was a problem hiding this comment.
A lot of test cases are failed.
|
/merge |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 6034211 |
cherry-pick #23161 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23295After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #xxx
Different default charsets in different drivers(or versions) make SQL bind cannot work.
So we don't let SPM be affected by charset.
We add a flag
RestoreStringWithoutCharsetto control this.Need to merge parser pr first
Related changes
Check List
Tests
Side effects
Release note