Skip to content

brie: update test to create mutli tables#18993

Merged
AilinKid merged 2 commits intopingcap:masterfrom
3pointer:fix_brie
Aug 6, 2020
Merged

brie: update test to create mutli tables#18993
AilinKid merged 2 commits intopingcap:masterfrom
3pointer:fix_brie

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented Aug 5, 2020

What problem does this PR solve?

Problem Summary:
TiDB does not support create table concurrently in Restore SQL, so we add a test, and set pool-size to 1 in BR. and update BR go mod.

What is changed and how it works?

add a test, and set pool-size to 1 in pingcap/br#449

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@3pointer
Copy link
Contributor Author

3pointer commented Aug 5, 2020

/run-check_dev_2

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #18993 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18993   +/-   ##
===========================================
  Coverage   79.4691%   79.4691%           
===========================================
  Files           546        546           
  Lines        148172     148172           
===========================================
  Hits         117751     117751           
  Misses        20954      20954           
  Partials       9467       9467           

Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2020
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 6, 2020
@jebter
Copy link

jebter commented Aug 6, 2020

/merge

@AilinKid AilinKid merged commit 031143a into pingcap:master Aug 6, 2020
3pointer added a commit to 3pointer/tidb that referenced this pull request Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants