This repository was archived by the owner on Jul 24, 2024. It is now read-only.
brieSQL: fix multi-thread panic during SQL restore (#448)#449
Merged
3pointer merged 1 commit intopingcap:release-4.0from Aug 5, 2020
Merged
brieSQL: fix multi-thread panic during SQL restore (#448)#4493pointer merged 1 commit intopingcap:release-4.0from
3pointer merged 1 commit intopingcap:release-4.0from
Conversation
Collaborator
Author
|
/run-integration-tests |
Member
|
LGTM |
ti-srebot
approved these changes
Aug 5, 2020
This was referenced Aug 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #448 to release-4.0
What problem does this PR solve?
In SQL restore. we choose one session to execute SQL,
so we can't simple use dbPool to create table concurrently.
What is changed and how it works?
In restore. if we are using SQL
glue.OwnerStorage()will return false.so we use this condition to tell whether we should make dbPool or not.
Check List
Tests
test will include in brie: update test to create mutli tables tidb#18993
Code changes
Side effects
Related changes
Release Note