Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

brieSQL: fix multi-thread panic during SQL restore (#448)#449

Merged
3pointer merged 1 commit intopingcap:release-4.0from
3pointer:release-4.0
Aug 5, 2020
Merged

brieSQL: fix multi-thread panic during SQL restore (#448)#449
3pointer merged 1 commit intopingcap:release-4.0from
3pointer:release-4.0

Conversation

@3pointer
Copy link
Collaborator

@3pointer 3pointer commented Aug 5, 2020

cherry-pick #448 to release-4.0

What problem does this PR solve?

In SQL restore. we choose one session to execute SQL,
so we can't simple use dbPool to create table concurrently.

What is changed and how it works?

In restore. if we are using SQL glue.OwnerStorage() will return false.
so we use this condition to tell whether we should make dbPool or not.

Check List

Tests

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Note

  • No release note

@3pointer 3pointer requested review from kennytm and overvenus August 5, 2020 08:07
@3pointer
Copy link
Collaborator Author

3pointer commented Aug 5, 2020

/run-integration-tests

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Aug 5, 2020
@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants