Skip to content

brie: update test to create mutli tables (#18993)#19026

Merged
ti-srebot merged 2 commits intopingcap:release-4.0from
3pointer:pick_4.0
Aug 6, 2020
Merged

brie: update test to create mutli tables (#18993)#19026
ti-srebot merged 2 commits intopingcap:release-4.0from
3pointer:pick_4.0

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented Aug 6, 2020

cherry-pick #18993 to release-4.0

What problem does this PR solve?

Problem Summary:
TiDB does not support create table concurrently in Restore SQL, so we add a test, and set pool-size to 1 in BR. and update BR go mod.

What is changed and how it works?

add a test, and set pool-size to 1 in pingcap/br#449

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 6, 2020
@jebter
Copy link

jebter commented Aug 6, 2020

/run-unit-test

@jebter
Copy link

jebter commented Aug 6, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 65a33ba into pingcap:release-4.0 Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants