Add more fields in DiffSchema for exchanging partition#883
Merged
tiancaiamao merged 18 commits intopingcap:masterfrom Jun 9, 2020
zhaox1n:master
Merged
Add more fields in DiffSchema for exchanging partition#883tiancaiamao merged 18 commits intopingcap:masterfrom zhaox1n:master
tiancaiamao merged 18 commits intopingcap:masterfrom
zhaox1n:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
==========================================
- Coverage 78.32% 78.29% -0.03%
==========================================
Files 40 40
Lines 14708 14700 -8
==========================================
- Hits 11520 11510 -10
- Misses 2505 2507 +2
Partials 683 683 |
tiancaiamao
reviewed
Jun 2, 2020
zimulala
reviewed
Jun 4, 2020
Co-authored-by: Lynn <zimu_xia@126.com>
kennytm
reviewed
Jun 4, 2020
zimulala
reviewed
Jun 5, 2020
Contributor
|
PTAL @tiancaiamao @kennytm |
zimulala
reviewed
Jun 8, 2020
Contributor
zimulala
left a comment
There was a problem hiding this comment.
Besides, maybe we need to add a field to BinlogInfo.
zimulala
reviewed
Jun 8, 2020
Contributor
zimulala
left a comment
There was a problem hiding this comment.
Besides, maybe we need to add a field to BinlogInfo.
Confirmed with classmates of drainer and CDC, no new fields need to be added at present.
Collaborator
|
LGTM |
tiancaiamao
approved these changes
Jun 9, 2020
tiancaiamao
added a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Co-authored-by: Lynn <zimu_xia@126.com> Co-authored-by: kennytm <kennytm@gmail.com> Co-authored-by: tiancaiamao <tiancaiamao@gmail.com>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
While exchanging partition affects 2 tables, we need to expand
DiffSchema. Related PR in TIDB #17149What is changed and how it works?
Check List
Tests
Side effects
Release note