Skip to content

parser: support grammar use index(primary) without backquote#2

Merged
XuHuaiyu merged 2 commits intopingcap:masterfrom
XuHuaiyu:use_primary
Nov 1, 2018
Merged

parser: support grammar use index(primary) without backquote#2
XuHuaiyu merged 2 commits intopingcap:masterfrom
XuHuaiyu:use_primary

Conversation

@XuHuaiyu
Copy link
Contributor

fix the issue raised in pingcap/tidb#8038

@kennytm
Copy link
Contributor

kennytm commented Oct 25, 2018

parser.go isn't updated 😐

Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is an important feature: I have used FORCE INDEX (PRIMARY) many times, and never escape it.

@ngaut
Copy link
Member

ngaut commented Nov 1, 2018

LGTM

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Nov 1, 2018

PTAL @tiancaiamao

@XuHuaiyu XuHuaiyu removed the DNM label Nov 1, 2018
@XuHuaiyu XuHuaiyu merged commit 479633a into pingcap:master Nov 1, 2018
@XuHuaiyu XuHuaiyu deleted the use_primary branch November 1, 2018 10:59
spongedu pushed a commit to spongedu/parser that referenced this pull request Oct 17, 2019
Deardrops pushed a commit to Deardrops/parser that referenced this pull request May 9, 2020
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Jun 10, 2021
spongedu pushed a commit to spongedu/parser that referenced this pull request Nov 17, 2021
Support spatial index in create table statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants