ddl: Support exchange partition#17149
Merged
tiancaiamao merged 77 commits intopingcap:masterfrom Jun 10, 2020
zhaox1n:master
Merged
ddl: Support exchange partition#17149tiancaiamao merged 77 commits intopingcap:masterfrom zhaox1n:master
tiancaiamao merged 77 commits intopingcap:masterfrom
zhaox1n:master
Conversation
merge from master
merge tidb from master
Contributor
|
Thanks for your contribution. If your PR get merged, you will be rewarded 2530 points. |
Contributor
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Member
|
Hi @zhaox1n , thanks for your contribution! Please fix the CI firstly(for example, https://internal.pingcap.net/idc-jenkins/job/tidb_ghpr_build/36145/display/redirect): |
Deardrops
reviewed
May 13, 2020
Contributor
|
PTAL @crazycs520 |
Co-authored-by: Lynn <zimu_xia@126.com>
zhaox1n
commented
Jun 9, 2020
| // Index type is not compatible | ||
| if sourceIdx.Tp != compatIdx.Tp || | ||
| sourceIdx.Unique != compatIdx.Unique || | ||
| sourceIdx.Primary != compatIdx.Primary { |
Contributor
Author
There was a problem hiding this comment.
@crazycs520 It has compared the Primary key here.
Contributor
There was a problem hiding this comment.
No, they are different. For table create table t1 (a int key, b int, index (a));, the TableInfo.Indices is nil.
Contributor
|
Please resolve conflict @zhaox1n |
Contributor
|
@crazycs520 |
crazycs520
approved these changes
Jun 10, 2020
Contributor
|
/run-all-tests |
Contributor
|
@zhaox1n merge failed. |
Contributor
|
/run-unit-test |
Contributor
1 task
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UCP #15005
What is changed and how it works?
Support exchange partition
Check List
Tests
Release note