TST: Check pytables<3.5.1 when skipping#25773
Conversation
|
Really strange I also see no changes in the |
@gfyoung : there was a |
That's indeed not related. It is a failure with one of the dependencies. It might well be it is only temporary (eg when they are updating packages on conda-forge, there might be a moment not yet everything is matching with each other). But if it keeps failing, we can skip it for now. |
@jorisvandenbossche : Sounds good. I'll restart again tomorrow. |
|
Just restarted the build now |
|
@gfyoung you can just put a skip around geopandas for now (or pin to a prior version) |
|
we shouldn't block on installation issues of another library here. |
3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail.
e5b70ee to
9d61a0b
Compare
Codecov Report
@@ Coverage Diff @@
## master #25773 +/- ##
=========================================
Coverage ? 41.76%
=========================================
Files ? 172
Lines ? 52965
Branches ? 0
=========================================
Hits ? 22122
Misses ? 30843
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #25773 +/- ##
=========================================
Coverage ? 91.26%
=========================================
Files ? 172
Lines ? 52965
Branches ? 0
=========================================
Hits ? 48338
Misses ? 4627
Partials ? 0
Continue to review full report at Codecov.
|
|
lgtm. ping on green. |
|
thanks @gfyoung |
* origin/master: DOC: clean bug fix section in whatsnew (pandas-dev#25792) DOC: Fixed PeriodArray api ref (pandas-dev#25526) Move locale code out of tm, into _config (pandas-dev#25757) Unpin pycodestyle (pandas-dev#25789) Add test for rdivmod on EA array (GH23287) (pandas-dev#24047) ENH: Support datetime.timezone objects (pandas-dev#25065) Cython language level 3 (pandas-dev#24538) API: concat on sparse values (pandas-dev#25719) TST: assert_produces_warning works with filterwarnings (pandas-dev#25721) make core.config self-contained (pandas-dev#25613) CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721) TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) DOC: Fix typo in docstring of DataFrame.memory_usage (pandas-dev#25770) Replace dicts with OrderedDicts in groupby aggregation functions (pandas-dev#25693) TST: Fixturize tests/frame/test_missing.py (pandas-dev#25640) DOC: Improve the docsting of Series.iteritems (pandas-dev#24879) DOC: Fix function name. (pandas-dev#25751) Implementing iso_week_year support for to_datetime (pandas-dev#25541) DOC: clarify corr behaviour when using a callable (pandas-dev#25732) remove unnecessary check_output (pandas-dev#25755) # Conflicts: # doc/source/whatsnew/v0.25.0.rst
* TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) * TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778 added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without) fixed lint error Fixed code issue from compat with new numpydoc (pandas-dev#26188) fixed docstring
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) * TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778 added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without) fixed lint error Fixed code issue from compat with new numpydoc (pandas-dev#26188) fixed docstring
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) * TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778 added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without) fixed lint error Fixed code issue from compat with new numpydoc (pandas-dev#26188) fixed docstring
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) * TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778 added 'except NULL' for get_c_string_buf_and_size in util.pxd(bug without) fixed lint error Fixed code issue from compat with new numpydoc (pandas-dev#26188) fixed docstring
3.5.1was made available onconda, causingxfail_non_writeabletests to fail.Note that this is just to get
masterto pass again (started failing when #25751 was merged).This new release of
pytables, however, brings up the question of how we want to proceed with #24839, as it appears that all of our CI builds that installpytableswill use this version now.It seems a little early to declare that
3.5.1is our minimum version, but it definitely looks like we could drop thisxfailfrom our tests at some point in the near future.