DOC: Improve the docsting of Series.iteritems by HubertKl · Pull Request #24879 · pandas-dev/pandas

HubertKl · 2019-01-22T22:31:40Z

closes #xxxx
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

codecov · 2019-01-22T23:08:23Z

Codecov Report

Merging #24879 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24879   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files         166      166           
  Lines       52410    52410           
=======================================
  Hits        48422    48422           
  Misses       3988     3988

Flag	Coverage Δ
#multiple	`90.81% <ø> (ø)`	⬆️
#single	`42.88% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/series.py	`93.68% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 853cd70...92ab782. Read the comment docs.

codecov · 2019-01-22T23:08:32Z

Codecov Report

Merging #24879 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24879      +/-   ##
==========================================
- Coverage   91.25%   91.25%   -0.01%     
==========================================
  Files         172      172              
  Lines       52977    52977              
==========================================
- Hits        48343    48342       -1     
- Misses       4634     4635       +1

Flag	Coverage Δ
#multiple	`89.82% <ø> (ø)`	⬆️
#single	`41.74% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/series.py	`93.68% <ø> (ø)`	⬆️
pandas/util/testing.py	`88.98% <0%> (-0.1%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c0441...15735ef. Read the comment docs.

TomAugspurger

Looks nice overall.

I'm not entirely sure about the focus on "creating a new series". I think the thing to focus on is other functions that can only take scalar inputs (are not vectorized). You can do many things with the output of the non-vectorized method (including creating a new series).

TomAugspurger · 2019-01-23T03:44:59Z

pandas/core/series.py

        """
        Lazily iterate over (index, value) tuples.
+
+        This method returns a zip of tuples (index, value). This is useful When


How about "iterable" instead of "zip"?

TomAugspurger · 2019-01-23T03:45:39Z

pandas/core/series.py

        Lazily iterate over (index, value) tuples.
+
+        This method returns a zip of tuples (index, value). This is useful When
+        one want to create new series from the values of an old one. Be aware


"one wants" (but "you want" probably sounds better)

I'm not sure about creating a new series using itertuples. I'd rather say something about lazily iterating over the index, value pairs.

I am not sure to perfectly get what you mean. I tried to add an example where vectorization is not possible (as far as I know maybe I am wrong)

TomAugspurger · 2019-01-23T03:47:25Z

pandas/core/series.py

+
+        Returns
+        -------
+        zip


I wonder if people have thoughts here. I guess zip is technically a type... But I think Iterable is probably better-known.

I agree. I think iterable would be more user-friendly.

TomAugspurger · 2019-01-23T03:47:49Z

pandas/core/series.py

+        Returns
+        -------
+        zip
+            Iterable tuples (index, value) of the Series.


Iterable of tuples containing the (index, value) pairs from a Series.

HubertKl · 2019-01-23T23:52:17Z

Thanks for those comments, I tried to improve the docstring accordingly to your remarks.

…Series_iteritems

mroeschke · 2019-01-27T07:44:40Z

pandas/core/series.py

        Lazily iterate over (index, value) tuples.
+
+        This method returns an iterable tuple (index, value). This is
+        convienient if you want to create a a Lazy iterator.


There are 2 as on this line. Lowercase l on Lazy

mroeschke · 2019-01-27T07:45:54Z

pandas/core/series.py

+
+        See Also
+        --------
+        Series.apply : Invoke function on values of Series.


Not sure if Series.apply and Series.map are too related to this method. I would instead reference Series.items

Unless I am mistaken, it seems to me that Series.iteritems and Series.items are the same method. The docstring of items and iteritems will be the same I don't think that this is a good idea.

I will mention it in the description instead.

I agree that apply and map aren't closely enough related to include here - can you remove?

pep8speaks · 2019-01-31T22:06:37Z

Hello @HubertKl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-16 10:50:43 UTC

WillAyd

Minor comment otherwise lgtm

WillAyd · 2019-02-28T00:32:49Z

pandas/core/series.py

+
+        See Also
+        --------
+        Series.apply : Invoke function on values of Series.


I agree that apply and map aren't closely enough related to include here - can you remove?

TomAugspurger · 2019-03-05T16:09:08Z

@HubertKl can you update, removing Series.apply and Series.map in the See Also?

jreback · 2019-03-10T23:21:07Z

@HubertKl can you update to comments

…Series_iteritems

HubertKl · 2019-03-16T10:51:43Z

Sorry for the delay. I modified the PR accordingly to the requests.

WillAyd · 2019-03-19T03:48:23Z

Thanks @HubertKl !

* origin/master: DOC: clean bug fix section in whatsnew (pandas-dev#25792) DOC: Fixed PeriodArray api ref (pandas-dev#25526) Move locale code out of tm, into _config (pandas-dev#25757) Unpin pycodestyle (pandas-dev#25789) Add test for rdivmod on EA array (GH23287) (pandas-dev#24047) ENH: Support datetime.timezone objects (pandas-dev#25065) Cython language level 3 (pandas-dev#24538) API: concat on sparse values (pandas-dev#25719) TST: assert_produces_warning works with filterwarnings (pandas-dev#25721) make core.config self-contained (pandas-dev#25613) CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721) TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) DOC: Fix typo in docstring of DataFrame.memory_usage (pandas-dev#25770) Replace dicts with OrderedDicts in groupby aggregation functions (pandas-dev#25693) TST: Fixturize tests/frame/test_missing.py (pandas-dev#25640) DOC: Improve the docsting of Series.iteritems (pandas-dev#24879) DOC: Fix function name. (pandas-dev#25751) Implementing iso_week_year support for to_datetime (pandas-dev#25541) DOC: clarify corr behaviour when using a callable (pandas-dev#25732) remove unnecessary check_output (pandas-dev#25755) # Conflicts: # doc/source/whatsnew/v0.25.0.rst

DOC: Improve the docsting of Series.iteritems

92ab782

TomAugspurger reviewed Jan 23, 2019

View reviewed changes

gfyoung added the Docs label Jan 23, 2019

Corrections added

0aa8a10

Moi added 2 commits January 27, 2019 00:33

Merge remote-tracking branch 'upstream/master' into docstring_pandas_…

a8b96e6

…Series_iteritems

Corrections

baaaa07

mroeschke reviewed Jan 27, 2019

View reviewed changes

Corrections added

45d7841

corrections

d062f8d

WillAyd requested changes Feb 28, 2019

View reviewed changes

Moi added 2 commits March 16, 2019 11:48

minor changes

b0da5c3

Merge remote-tracking branch 'upstream/master' into docstring_pandas_…

15735ef

…Series_iteritems

WillAyd approved these changes Mar 19, 2019

View reviewed changes

WillAyd added this to the 0.25.0 milestone Mar 19, 2019

WillAyd merged commit 406e7ea into pandas-dev:master Mar 19, 2019

Uh oh!

Conversation

HubertKl commented Jan 22, 2019

Uh oh!

codecov bot commented Jan 22, 2019

Codecov Report

Uh oh!

codecov bot commented Jan 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

TomAugspurger left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HubertKl commented Jan 23, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pep8speaks commented Jan 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2019-03-16 10:50:43 UTC

Uh oh!

WillAyd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomAugspurger commented Mar 5, 2019

Uh oh!

jreback commented Mar 10, 2019

Uh oh!

HubertKl commented Mar 16, 2019

Uh oh!

WillAyd commented Mar 19, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov bot commented Jan 22, 2019 •

edited

Loading

pep8speaks commented Jan 31, 2019 •

edited

Loading