remove unnecessary check_output copy/pasted code#25755
Merged
jreback merged 1 commit intopandas-dev:masterfrom Mar 18, 2019
Merged
remove unnecessary check_output copy/pasted code#25755jreback merged 1 commit intopandas-dev:masterfrom
jreback merged 1 commit intopandas-dev:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25755 +/- ##
==========================================
+ Coverage 91.25% 91.26% +<.01%
==========================================
Files 172 172
Lines 52977 52965 -12
==========================================
- Hits 48342 48336 -6
+ Misses 4635 4629 -6
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #25755 +/- ##
==========================================
+ Coverage 91.25% 91.26% +<.01%
==========================================
Files 172 172
Lines 52977 52965 -12
==========================================
- Hits 48342 48336 -6
+ Misses 4635 4629 -6
Continue to review full report at Codecov.
|
Contributor
|
thanks! |
sighingnow
added a commit
to sighingnow/pandas
that referenced
this pull request
Mar 20, 2019
* origin/master: DOC: clean bug fix section in whatsnew (pandas-dev#25792) DOC: Fixed PeriodArray api ref (pandas-dev#25526) Move locale code out of tm, into _config (pandas-dev#25757) Unpin pycodestyle (pandas-dev#25789) Add test for rdivmod on EA array (GH23287) (pandas-dev#24047) ENH: Support datetime.timezone objects (pandas-dev#25065) Cython language level 3 (pandas-dev#24538) API: concat on sparse values (pandas-dev#25719) TST: assert_produces_warning works with filterwarnings (pandas-dev#25721) make core.config self-contained (pandas-dev#25613) CLN: replace %s syntax with .format in pandas.io.parsers (pandas-dev#24721) TST: Check pytables<3.5.1 when skipping (pandas-dev#25773) DOC: Fix typo in docstring of DataFrame.memory_usage (pandas-dev#25770) Replace dicts with OrderedDicts in groupby aggregation functions (pandas-dev#25693) TST: Fixturize tests/frame/test_missing.py (pandas-dev#25640) DOC: Improve the docsting of Series.iteritems (pandas-dev#24879) DOC: Fix function name. (pandas-dev#25751) Implementing iso_week_year support for to_datetime (pandas-dev#25541) DOC: clarify corr behaviour when using a callable (pandas-dev#25732) remove unnecessary check_output (pandas-dev#25755) # Conflicts: # doc/source/whatsnew/v0.25.0.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It isn't clear to me why this is needed. Maybe the CI will fail, in which case I'll just add a comment in the code explaining why it is needed.