Closure offsets: make adding constraints pure, change accumulation algorithm#552
Merged
mshinwell merged 7 commits intooxcaml:mainfrom Feb 24, 2022
Merged
Closure offsets: make adding constraints pure, change accumulation algorithm#552mshinwell merged 7 commits intooxcaml:mainfrom
mshinwell merged 7 commits intooxcaml:mainfrom
Conversation
This reflects the ability to make individual code bindings deleted during the rebuilding step.
dda19be to
7620321
Compare
Gbury
requested changes
Feb 23, 2022
Contributor
Gbury
left a comment
There was a problem hiding this comment.
I'm worried about the part of the diff in simplify_set_of_closures (see comment), I'll try and come up with a fix for that.
Gbury
approved these changes
Feb 24, 2022
Gbury
approved these changes
Feb 24, 2022
mshinwell
approved these changes
Feb 24, 2022
mshinwell
pushed a commit
that referenced
this pull request
Mar 3, 2022
…gorithm (#552) Co-authored-by: Guillaume Bury <guillaume.bury@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #532, based on top of #551