Simplify code stubs at definition and do not specialise them#532
Merged
lthls merged 1 commit intooxcaml:mainfrom Feb 24, 2022
Merged
Simplify code stubs at definition and do not specialise them#532lthls merged 1 commit intooxcaml:mainfrom
lthls merged 1 commit intooxcaml:mainfrom
Conversation
poechsel
approved these changes
Feb 16, 2022
0464570 to
02f3a86
Compare
This was referenced Feb 22, 2022
2afa5fc to
f1a9e97
Compare
Contributor
Author
|
This branch has been rebased on top of main + #552. There are a few changes still on this PR that could have been split (most notably the change in |
f1a9e97 to
a884107
Compare
mshinwell
approved these changes
Feb 23, 2022
a884107 to
322f8ca
Compare
mshinwell
pushed a commit
that referenced
this pull request
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change is only one commit (Simplify code stubs at definition only), but there are a number of other commits that fix various bugs that would trigger otherwise, and one commit (Allow metadata-only code in environments) that does not fix a bug but could be cleanly split from the main commit and should be mostly a no-op, making it easier to review independently.