Data flow: do not enforce dependencies on mutually defined code IDs#551
Merged
mshinwell merged 2 commits intooxcaml:mainfrom Feb 23, 2022
Merged
Data flow: do not enforce dependencies on mutually defined code IDs#551mshinwell merged 2 commits intooxcaml:mainfrom
mshinwell merged 2 commits intooxcaml:mainfrom
Conversation
This reflects the ability to make individual code bindings deleted during the rebuilding step.
mshinwell
approved these changes
Feb 23, 2022
mshinwell
pushed a commit
that referenced
this pull request
Mar 3, 2022
…551) This reflects the ability to make individual code bindings deleted during the rebuilding step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reflects the ability to make individual code bindings deleted during the rebuilding step.
This PR helps ensuring that code that has never gone through
Simplifycannot end up in the final term.Here is one example that was problematic (from the
Queuemodule):Here simplifying the partial application of
auxcreates a new code ID (aux_n0_partial_n1), and a new set of closures that uses this code ID.When the set of closures is simplified, a new version of the code ID is created (
aux_n0_partial_n2), and we end up at toplevel with four lifted bindings: the closure symbolaux_n0, the specialised code IDaux_n0_n3, and both versions of the partial code stub. The only dependency to the old partial code ID is through thenewer_version_offield of the new partial code ID, but because of that dependencyLifted_constant_statehas to group all bindings together (otherwise we would get first the three other bindings together, then the old partial code ID binding; but this means that the new partial code ID is defined as the newer version of a code ID that isn't bound yet, and we don't want that to be allowed).The property that all code in the result term must have gone through Simplify will become required in a subsequent PR for closure offsets.