Skip to content

feat!: replace FileSystem::canonicalize with FileSystem::read_link#331

Merged
Boshen merged 1 commit intomainfrom
12-11-feat_replace_filesystem_canonicalize_with_filesystem_read_link_
Dec 11, 2024
Merged

feat!: replace FileSystem::canonicalize with FileSystem::read_link#331
Boshen merged 1 commit intomainfrom
12-11-feat_replace_filesystem_canonicalize_with_filesystem_read_link_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Dec 11, 2024

No description provided.

@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 79.62963% with 22 lines in your changes missing coverage. Please review.

Project coverage is 96.20%. Comparing base (cc3b760) to head (e215f8d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/file_system.rs 64.44% 16 Missing ⚠️
src/cache.rs 90.32% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   96.90%   96.20%   -0.70%     
==========================================
  Files          11       11              
  Lines        2454     2476      +22     
==========================================
+ Hits         2378     2382       +4     
- Misses         76       94      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 11, 2024

CodSpeed Performance Report

Merging #331 will not alter performance

Comparing 12-11-feat_replace_filesystem_canonicalize_with_filesystem_read_link_ (e215f8d) with main (cc3b760)

Summary

✅ 3 untouched benchmarks

@Boshen Boshen force-pushed the 12-11-feat_replace_filesystem_canonicalize_with_filesystem_read_link_ branch 4 times, most recently from 836468d to bc5b872 Compare December 11, 2024 14:38
@Boshen Boshen force-pushed the 12-11-feat_replace_filesystem_canonicalize_with_filesystem_read_link_ branch from bc5b872 to e215f8d Compare December 11, 2024 15:38
@Boshen Boshen merged commit 17441f8 into main Dec 11, 2024
@Boshen Boshen deleted the 12-11-feat_replace_filesystem_canonicalize_with_filesystem_read_link_ branch December 11, 2024 15:58
@Boshen Boshen mentioned this pull request Dec 11, 2024
Boshen added a commit that referenced this pull request Dec 12, 2024
## 🤖 New release
* `oxc_resolver`: 2.1.1 -> 3.0.0 (⚠️ API breaking changes)

### ⚠️ `oxc_resolver` breaking changes

```
--- failure trait_method_added: pub trait method added ---

Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/trait_method_added.ron

Failed in:
  trait method oxc_resolver::FileSystem::read_link in file /tmp/.tmptmsXac/oxc-resolver/src/file_system.rs:52

--- failure trait_method_missing: pub trait method removed or renamed ---

Description:
A trait method is no longer callable, and may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/trait_method_missing.ron

Failed in:
  method canonicalize of trait FileSystem, previously in file /tmp/.tmpa9nJqt/oxc_resolver/src/file_system.rs:62
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[3.0.0](oxc_resolver-v2.1.1...oxc_resolver-v3.0.0)
- 2024-12-12

### Added

- [**breaking**] replace `FileSystem::canonicalize` with
`FileSystem::read_link` (#331)
- faster and stable path hash for the cache (#328)

### Other

- guard `load_alias` on hot path (#339)
- use `as_os_str` for `Hash` and `PartialEq` operations (#338)
- run clippy with `--all-targets` (#333)
- increase hash size (#329)
- add dprint (#326)
- update dependencies
- *(deps)* update rust crates
- update README logo
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant