Skip to content

chore: increase hash size#329

Merged
Boshen merged 1 commit intomainfrom
cache
Dec 5, 2024
Merged

chore: increase hash size#329
Boshen merged 1 commit intomainfrom
cache

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Dec 5, 2024

No description provided.

@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.94%. Comparing base (790332c) to head (622404b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          11       11           
  Lines        2458     2458           
=======================================
  Hits         2383     2383           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 5, 2024

CodSpeed Performance Report

Merging #329 will degrade performances by 6.87%

Comparing cache (622404b) with main (790332c)

Summary

❌ 1 regressions
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cache Change
resolver[multi-thread] 449.7 µs 482.8 µs -6.87%

@Boshen Boshen merged commit a6bfe2a into main Dec 5, 2024
@Boshen Boshen deleted the cache branch December 5, 2024 16:04
@Boshen Boshen mentioned this pull request Dec 5, 2024
Boshen added a commit that referenced this pull request Dec 12, 2024
## 🤖 New release
* `oxc_resolver`: 2.1.1 -> 3.0.0 (⚠️ API breaking changes)

### ⚠️ `oxc_resolver` breaking changes

```
--- failure trait_method_added: pub trait method added ---

Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/trait_method_added.ron

Failed in:
  trait method oxc_resolver::FileSystem::read_link in file /tmp/.tmptmsXac/oxc-resolver/src/file_system.rs:52

--- failure trait_method_missing: pub trait method removed or renamed ---

Description:
A trait method is no longer callable, and may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.37.0/src/lints/trait_method_missing.ron

Failed in:
  method canonicalize of trait FileSystem, previously in file /tmp/.tmpa9nJqt/oxc_resolver/src/file_system.rs:62
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[3.0.0](oxc_resolver-v2.1.1...oxc_resolver-v3.0.0)
- 2024-12-12

### Added

- [**breaking**] replace `FileSystem::canonicalize` with
`FileSystem::read_link` (#331)
- faster and stable path hash for the cache (#328)

### Other

- guard `load_alias` on hot path (#339)
- use `as_os_str` for `Hash` and `PartialEq` operations (#338)
- run clippy with `--all-targets` (#333)
- increase hash size (#329)
- add dprint (#326)
- update dependencies
- *(deps)* update rust crates
- update README logo
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant