Skip to content

fix(semantic): use correct scope flags for using declarations#9751

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations
Mar 18, 2025
Merged

fix(semantic): use correct scope flags for using declarations#9751
graphite-app[bot] merged 1 commit into
mainfrom
c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations

Conversation

@camc314

@camc314 camc314 commented Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #9666

@github-actions github-actions Bot added A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels Mar 13, 2025
@camc314 Graphite App

camc314 commented Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from c117e01 to 354b424 Compare March 13, 2025 12:10
@github-actions github-actions Bot added the A-linter Area - Linter label Mar 13, 2025
@camc314 camc314 marked this pull request as ready for review March 13, 2025 12:10
@camc314 camc314 requested review from Boshen and Dunqing as code owners March 13, 2025 12:10
@codspeed-hq

codspeed-hq Bot commented Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #9751 will not alter performance

Comparing c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations (bc8bc08) with main (b3ce925)

Summary

✅ 33 untouched benchmarks

@camc314 camc314 force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from 354b424 to 8516bd5 Compare March 13, 2025 12:13
@camc314 camc314 changed the base branch from main to graphite-base/9751 March 13, 2025 12:31
@camc314 camc314 force-pushed the graphite-base/9751 branch from cd3f2fb to 3f73d01 Compare March 13, 2025 12:31
@camc314 camc314 force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from 8516bd5 to f0ec0bb Compare March 13, 2025 12:31
@camc314 camc314 changed the base branch from graphite-base/9751 to c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl March 13, 2025 12:31
@camc314 camc314 mentioned this pull request Mar 13, 2025
Merged
@camc314 camc314 changed the base branch from c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl to graphite-base/9751 March 13, 2025 12:34
@camc314 camc314 force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from f0ec0bb to 6707621 Compare March 13, 2025 12:38
@camc314 camc314 force-pushed the graphite-base/9751 branch from 3f73d01 to 9a6702a Compare March 13, 2025 12:38
@camc314 camc314 changed the base branch from graphite-base/9751 to c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl March 13, 2025 12:38
@github-actions github-actions Bot added the A-minifier Area - Minifier label Mar 13, 2025
@camc314 camc314 force-pushed the c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl branch from 9a6702a to 12e19b9 Compare March 13, 2025 12:40
@camc314 camc314 force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch 2 times, most recently from 208ff32 to 27fb1ae Compare March 13, 2025 12:57
@github-actions github-actions Bot added the A-ast Area - AST label Mar 13, 2025
@camc314 camc314 force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from 27fb1ae to bb26d9a Compare March 13, 2025 12:59
@camc314 camc314 requested a review from overlookmotel March 13, 2025 13:00
@camc314 camc314 force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from bb26d9a to 06aabfd Compare March 13, 2025 13:10
Dunqing
Dunqing previously approved these changes Mar 13, 2025
View reviewed changes
@Dunqing Dunqing dismissed their stale review March 13, 2025 14:13

Mistake

Dunqing
Dunqing previously requested changes Mar 13, 2025
View reviewed changes
Comment thread crates/oxc_ast/src/ast_impl/js.rs
@camc314 camc314 force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from 06aabfd to 1d3ed9b Compare March 13, 2025 14:28
@camc314 camc314 requested a review from Dunqing March 13, 2025 14:28
overlookmotel
overlookmotel reviewed Mar 14, 2025
View reviewed changes

@overlookmotel overlookmotel left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. A few small comments below.

Also, judging by the names of the conformance tests (transform-sync), it looks like this change only causes semantic errors in tests relating to using, but not await using. Seems odd.

Maybe the tests don't contain any cases where await using is in a nested block, and that explains it. But I think worth checking, if you didn't already.

Comment thread crates/oxc_linter/src/rules/eslint/no_case_declarations.rs Outdated
Comment thread crates/oxc_semantic/src/binder.rs Outdated
Comment thread crates/oxc_semantic/tests/fixtures/oxc/js/declarations/using.js
@camc314 camc314 force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch 3 times, most recently from 2e0280e to 15f3481 Compare March 14, 2025 09:34
@Boshen Boshen requested a review from overlookmotel March 15, 2025 14:01
@graphite-app graphite-app Bot changed the base branch from c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl to graphite-base/9751 March 15, 2025 14:02
@graphite-app graphite-app Bot force-pushed the graphite-base/9751 branch from 12e19b9 to f707d1f Compare March 15, 2025 14:07
@graphite-app graphite-app Bot force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from 51c14f5 to b7def02 Compare March 15, 2025 14:07
@graphite-app graphite-app Bot changed the base branch from graphite-base/9751 to main March 15, 2025 14:08
@graphite-app graphite-app Bot force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from b7def02 to 388f955 Compare March 15, 2025 14:08
@overlookmotel overlookmotel dismissed Dunqing’s stale review March 18, 2025 06:58

Dunqing's feedback was addressed.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
@overlookmotel Graphite App

overlookmotel commented Mar 18, 2025 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Member

Merge activity

  • Mar 18, 2:58 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 18, 2:58 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 18, 3:06 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app Bot force-pushed the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch from 388f955 to bc8bc08 Compare March 18, 2025 06:59
@graphite-app graphite-app Bot merged commit bc8bc08 into main Mar 18, 2025
@graphite-app graphite-app Bot deleted the c/03-13-fix_semantic_use_correct_scope_flags_for_using_declarations branch March 18, 2025 07:06
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
This was referenced Mar 18, 2025
Merged
Merged
graphite-app Bot pushed a commit that referenced this pull request Mar 18, 2025
@overlookmotel
fix(linter/no_case_declarations): fix span of error for await using (…
73fe248 
…#9854)

Follow-on after #9751. Make the span in error for `await using` more accurate.
This was referenced Mar 18, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

@Boshen Boshen Awaiting requested review from Boshen

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-ast Area - AST A-linter Area - Linter A-minifier Area - Minifier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bindings declared with using should be block scoped and const

3 participants

@camc314 @overlookmotel @Dunqing