Skip to content

fix(linter/no_case_declarations): fix span of error for await using#9854

Merged
graphite-app[bot] merged 1 commit into
mainfrom
03-18-fix_linter_no_case_declarations_fix_span_of_error_for_await_using_
Mar 18, 2025
Merged

fix(linter/no_case_declarations): fix span of error for await using#9854
graphite-app[bot] merged 1 commit into
mainfrom
03-18-fix_linter_no_case_declarations_fix_span_of_error_for_await_using_

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Mar 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Follow-on after #9751. Make the span in error for await using more accurate.

@overlookmotel Graphite App

overlookmotel commented Mar 18, 2025

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-linter Area - Linter C-bug Category - Bug labels Mar 18, 2025
@overlookmotel overlookmotel marked this pull request as ready for review March 18, 2025 07:19
@overlookmotel overlookmotel requested a review from camc314 March 18, 2025 07:19
@overlookmotel

overlookmotel commented Mar 18, 2025

Copy link
Copy Markdown
Member Author

@camc314 I think this is better - the span doesn't include whitespace after using. This is on a cold path - lint rules should pass without erroring 99% of the time (because likely the user already fixed any errors) - so I don't think the extra work matters. But I don't know the linter well at all - so maybe I'm missing something?

@codspeed-hq

codspeed-hq Bot commented Mar 18, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #9854 will not alter performance

Comparing 03-18-fix_linter_no_case_declarations_fix_span_of_error_for_await_using_ (73fe248) with main (bc8bc08)

Summary

✅ 33 untouched benchmarks

camc314
camc314 approved these changes Mar 18, 2025
View reviewed changes

@camc314 camc314 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this works. my main concern was multi byte chars and comments, but this should be fine

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
@camc314 Graphite App

camc314 commented Mar 18, 2025 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Contributor

Merge activity

  • Mar 18, 3:32 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 18, 3:32 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 18, 3:37 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel
fix(linter/no_case_declarations): fix span of error for await using (…
73fe248 
…#9854)

Follow-on after #9751. Make the span in error for `await using` more accurate.
@graphite-app graphite-app Bot force-pushed the 03-18-fix_linter_no_case_declarations_fix_span_of_error_for_await_using_ branch from 517a7d4 to 73fe248 Compare March 18, 2025 07:32
@graphite-app graphite-app Bot merged commit 73fe248 into main Mar 18, 2025
@graphite-app graphite-app Bot deleted the 03-18-fix_linter_no_case_declarations_fix_span_of_error_for_await_using_ branch March 18, 2025 07:37
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Mar 18, 2025
@oxc-bot oxc-bot mentioned this pull request Mar 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

No one assigned

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @camc314