Skip to content

fix(parser): set kind of var_declarator correctly for using decl#9753

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl
Mar 15, 2025
Merged

fix(parser): set kind of var_declarator correctly for using decl#9753
graphite-app[bot] merged 1 commit into
mainfrom
c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl

Conversation

@camc314

@camc314 camc314 commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

i think i broke this in my first ever pr 🤦‍♂️

camc314 commented Mar 13, 2025

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the A-parser Area - Parser label Mar 13, 2025
@camc314 camc314 marked this pull request as ready for review March 13, 2025 12:26
@github-actions github-actions Bot added the C-bug Category - Bug label Mar 13, 2025
@camc314 camc314 force-pushed the c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl branch from b13b91a to 3f73d01 Compare March 13, 2025 12:31
@camc314 camc314 requested review from Boshen and Dunqing March 13, 2025 12:31
@github-actions github-actions Bot added the A-minifier Area - Minifier label Mar 13, 2025
@camc314 camc314 force-pushed the c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl branch from 3f73d01 to 9a6702a Compare March 13, 2025 12:34
@codspeed-hq

codspeed-hq Bot commented Mar 13, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #9753 will not alter performance

Comparing c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl (f707d1f) with main (2c48fba)

Summary

✅ 33 untouched benchmarks

@camc314 camc314 force-pushed the c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl branch from 9a6702a to 12e19b9 Compare March 13, 2025 12:40
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 15, 2025

Boshen commented Mar 15, 2025

Copy link
Copy Markdown
Member

Merge activity

  • Mar 15, 10:01 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 15, 10:01 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 15, 10:07 AM EDT: A user merged this pull request with the Graphite merge queue.

i think i broke this in my first ever pr 🤦‍♂️
@graphite-app graphite-app Bot force-pushed the c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl branch from 12e19b9 to f707d1f Compare March 15, 2025 14:02
@graphite-app graphite-app Bot merged commit f707d1f into main Mar 15, 2025
@graphite-app graphite-app Bot deleted the c/03-13-fix_parser_set_kind_of_var_declarator_correctly_for_using_decl branch March 15, 2025 14:07
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants