Skip to content

refactor(isolated_declarations): switch to new AstBuilder#23839

Merged
graphite-app[bot] merged 1 commit into
mainfrom
om/06-26-refactor_isolated_declarations_switch_to_new_astbuilder_
Jun 26, 2026
Merged

refactor(isolated_declarations): switch to new AstBuilder#23839
graphite-app[bot] merged 1 commit into
mainfrom
om/06-26-refactor_isolated_declarations_switch_to_new_astbuilder_

Conversation

@overlookmotel

@overlookmotel overlookmotel commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of #23043. Migrate oxc_isolated_declarations over to new AstBuilder.

This was referenced Jun 26, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App

overlookmotel commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the A-isolated-declarations Isolated Declarations label Jun 26, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing om/06-26-refactor_isolated_declarations_switch_to_new_astbuilder_ (b274d8f) with om/06-26-feat_ecmascript_switch_to_new_astbuilder_ (31ba365)2

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on om/06-26-feat_ecmascript_switch_to_new_astbuilder_ (8de5122) during the generation of this report, so 83a710d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel marked this pull request as ready for review June 26, 2026 18:11
@overlookmotel overlookmotel requested a review from Dunqing as a code owner June 26, 2026 18:11
Copilot AI review requested due to automatic review settings June 26, 2026 18:11
Copilot AI reviewed Jun 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@overlookmotel overlookmotel self-assigned this Jun 26, 2026
@graphite-app

graphite-app Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge activity

@overlookmotel
refactor(isolated_declarations): switch to new AstBuilder (#23839)
b274d8f 
Part of #23043. Migrate `oxc_isolated_declarations` over to new `AstBuilder`.
@graphite-app graphite-app Bot force-pushed the om/06-26-feat_ecmascript_switch_to_new_astbuilder_ branch from 31ba365 to 8de5122 Compare June 26, 2026 18:19
@graphite-app graphite-app Bot force-pushed the om/06-26-refactor_isolated_declarations_switch_to_new_astbuilder_ branch from 8d30fb6 to b274d8f Compare June 26, 2026 18:19
Base automatically changed from om/06-26-feat_ecmascript_switch_to_new_astbuilder_ to main June 26, 2026 18:40
@graphite-app graphite-app Bot merged commit b274d8f into main Jun 26, 2026
39 checks passed
@graphite-app graphite-app Bot deleted the om/06-26-refactor_isolated_declarations_switch_to_new_astbuilder_ branch June 26, 2026 18:42
camc314 pushed a commit that referenced this pull request Jul 3, 2026
@overlookmotel @camc314
refactor(isolated_declarations): switch to new AstBuilder (#23839)
82511e3 
Part of #23043. Migrate `oxc_isolated_declarations` over to new `AstBuilder`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-isolated-declarations Isolated Declarations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel