refactor(minifier): KeepVar do not create new AstBuilder#23833
Merged
graphite-app[bot] merged 1 commit intoJun 26, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 26, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Merge activity
|
Part of #23043, following on after #23832. Avoid cloning `AstBuilder` in `KeepVars`. Instead pass `&AstBuilder` in to `get_variable_declaration` and `get_variable_declaration_statement`, which is the only place it's needed. This means it will work as intended once `AstBuilder` becomes stateful (to generate unique `NodeId`s for all AST nodes). If we cloned the builder, it would lose that state.
8b42c46 to
b7cd88d
Compare
f4ce0d0 to
bd85673
Compare
Base automatically changed from
om/06-25-refactor_minifier_switch_to_new_astbuilder_
to
main
June 26, 2026 18:39
graphite-app Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
…uilder (#24035) Migrates the two remaining `&AstBuilder` parameters in `KeepVar` to the new builder API convention (`&B where B: GetAstBuilder`), continuing #23832 / #23833. This also resolves the pedantic `trivially_copy_pass_by_ref` warning that fires in default-features clippy runs (`cargo clippy -p oxc_minifier -- -D warnings`), where `AstBuilder` is `Copy`. It could not be fixed by taking `AstBuilder` by value, because under `disable_old_builder` (enabled for this crate's tests) it is not `Copy`; the generic signature is clean in both configurations.
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
Part of #23043, following on after #23832. Avoid cloning `AstBuilder` in `KeepVars`. Instead pass `&AstBuilder` in to `get_variable_declaration` and `get_variable_declaration_statement`, which is the only place it's needed. This means it will work as intended once `AstBuilder` becomes stateful (to generate unique `NodeId`s for all AST nodes). If we cloned the builder, it would lose that state.
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
…uilder (#24035) Migrates the two remaining `&AstBuilder` parameters in `KeepVar` to the new builder API convention (`&B where B: GetAstBuilder`), continuing #23832 / #23833. This also resolves the pedantic `trivially_copy_pass_by_ref` warning that fires in default-features clippy runs (`cargo clippy -p oxc_minifier -- -D warnings`), where `AstBuilder` is `Copy`. It could not be fixed by taking `AstBuilder` by value, because under `disable_old_builder` (enabled for this crate's tests) it is not `Copy`; the generic signature is clean in both configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #23043, following on after #23832.
Avoid cloning
AstBuilderinKeepVars. Instead pass&AstBuilderin toget_variable_declarationandget_variable_declaration_statement, which is the only place it's needed.This means it will work as intended once
AstBuilderbecomes stateful (to generate uniqueNodeIds for all AST nodes). If we cloned the builder, it would lose that state.